From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034244AbcJaUq0 (ORCPT ); Mon, 31 Oct 2016 16:46:26 -0400 Received: from mail-yw0-f172.google.com ([209.85.161.172]:33861 "EHLO mail-yw0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S946721AbcJaUqV (ORCPT ); Mon, 31 Oct 2016 16:46:21 -0400 From: Kevin Hilman To: Laurent Pinchart Cc: Bartosz Golaszewski , Michael Turquette , Sekhar Nori , Rob Herring , Frank Rowand , Mark Rutland , Peter Ujfalusi , Russell King , LKML , arm-soc , linux-drm , linux-devicetree , Jyri Sarha , Tomi Valkeinen , David Airlie Subject: Re: [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes Organization: BayLibre References: <1477925138-23457-1-git-send-email-bgolaszewski@baylibre.com> <1477925138-23457-5-git-send-email-bgolaszewski@baylibre.com> <12222113.L5elJM2tqN@avalon> Date: Mon, 31 Oct 2016 14:46:17 -0600 In-Reply-To: <12222113.L5elJM2tqN@avalon> (Laurent Pinchart's message of "Mon, 31 Oct 2016 22:22:54 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Laurent Pinchart writes: > Hi Bartosz, > > Thank you for the patch. > > On Monday 31 Oct 2016 15:45:37 Bartosz Golaszewski wrote: >> Enable the MSTPRI configuration and DDR2/mDDR memory controller >> nodes on da850-lcdk. This is needed in order to adjust the memory >> throughput constraints for better tilcdc support. > > Is there a reason not to enable these unconditionally in da850.dtsi (or rather > not disabling them) instead of handling it per board ? Right. They should be enabled by default in DT. The drivers already have board-specific compatible checks. Kevin