From: Kevin Hilman <khilman@baylibre.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Dave Gerlach <d-gerlach@ti.com>, Nishanth Menon <nm@ti.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Keerthy <j-keerthy@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Tero Kristo <t-kristo@ti.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Sudeep Holla <sudeep.holla@arm.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel\@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pm\@vger.kernel.org" <linux-pm@vger.kernel.org>,
Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH 3/3] soc: ti: Add ti_sci_pm_domains driver
Date: Thu, 08 Sep 2016 10:38:27 -0700 [thread overview]
Message-ID: <m2mvjinvfw.fsf@baylibre.com> (raw)
In-Reply-To: <CAPDyKFo0Cb90BbY7ra6VDjb5frC5=VtmE3V6tDK=VosfPmod7Q@mail.gmail.com> (Ulf Hansson's message of "Thu, 8 Sep 2016 11:27:52 +0200")
Ulf Hansson <ulf.hansson@linaro.org> writes:
> [...]
>
>>
>> One more idea...
>>
>> Since you don't really have a domain (a group of devices), what you
>> really have is each device having an independent power switch, so as Ulf
>> suggested, what you really need is for all the devices to share the same
>> set of runtime PM callbacks that call SCI. The only difference is the
>> unique ID.
>>
>> Rather than using all of genpd, you could also just use a pm_domain
>> which is what genpd is built on top of (and also omap_device, which
>> you're probably familiar with also.)
>
> Even if this would work as well, the downside would be that you need
> to re-invent the parts related to the DT parsing, the probing/removal
> and attaching/detaching of the device to the PM domain.
>
> You probably don't want to go there... :-)
All you'd need to read from DT would be the device-specific ID for
TI-SCI, and that could be done at bind time with a notifier. The, in
that same notifier, if a TI-SCI ID exists, it would get added to the
pm_domain.
Anyways, your original proposal is much preferred if it can work. I'm
just throwing out another option because I really don't like one genpd
per device.
Kevin
next prev parent reply other threads:[~2016-09-08 17:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 23:56 [PATCH 0/3] ARM: K2G: Add support for TI-SCI Generic PM Domains Nishanth Menon
2016-08-19 23:56 ` [PATCH 1/3] Documentation: dt: Add TI-SCI " Nishanth Menon
2016-09-02 14:31 ` Rob Herring
2016-08-19 23:56 ` [PATCH 2/3] dt-bindings: genpd: Add K2G device definitions Nishanth Menon
2016-08-25 7:32 ` Ulf Hansson
2016-08-19 23:56 ` [PATCH 3/3] soc: ti: Add ti_sci_pm_domains driver Nishanth Menon
2016-08-25 7:27 ` Ulf Hansson
2016-08-26 23:37 ` Dave Gerlach
2016-08-30 19:43 ` Dave Gerlach
2016-08-30 20:26 ` Ulf Hansson
2016-09-06 20:28 ` Dave Gerlach
2016-09-07 18:38 ` Kevin Hilman
2016-09-08 9:27 ` Ulf Hansson
2016-09-08 17:38 ` Kevin Hilman [this message]
2016-09-08 18:04 ` Dave Gerlach
2016-09-09 8:34 ` Ulf Hansson
2016-09-08 9:18 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2mvjinvfw.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=rjw@rjwysocki.net \
--cc=rmk+kernel@armlinux.org.uk \
--cc=ssantosh@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=t-kristo@ti.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).