From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753894AbdAKSou (ORCPT ); Wed, 11 Jan 2017 13:44:50 -0500 Received: from mail-pg0-f42.google.com ([74.125.83.42]:33537 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752686AbdAKSos (ORCPT ); Wed, 11 Jan 2017 13:44:48 -0500 From: Kevin Hilman To: Guenter Roeck Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 32/62] watchdog: meson_gxbb_wdt: Convert to use device managed functions and other improvements Organization: BayLibre References: <1484091325-9199-1-git-send-email-linux@roeck-us.net> <1484095516-12720-1-git-send-email-linux@roeck-us.net> <1484095516-12720-2-git-send-email-linux@roeck-us.net> Date: Wed, 11 Jan 2017 10:44:45 -0800 In-Reply-To: <1484095516-12720-2-git-send-email-linux@roeck-us.net> (Guenter Roeck's message of "Tue, 10 Jan 2017 16:44:41 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Guenter Roeck writes: > Use device managed functions to simplify error handling, reduce > source code size, improve readability, and reduce the likelyhood of bugs. > Other improvements as listed below. > > The conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts used > to generate this commit log are available at > https://github.com/groeck/coccinelle-patches > > - Use devm_add_action_or_reset() for calls to clk_disable_unprepare > - Check return value from clk_prepare_enable() > - Replace 'val = e; return val;' with 'return e;' > - Replace 'if (e) return e; return 0;' with 'return e;' > - Drop assignments to otherwise unused variables > - Replace 'if (e) { return expr; }' with 'if (e) return expr;' > - Drop remove function > - Use devm_watchdog_register_driver() to register watchdog device > - Replace shutdown function with call to watchdog_stop_on_reboot() > > Cc: Carlo Caione > Cc: Kevin Hilman > Signed-off-by: Guenter Roeck Nice, thanks for the cleanup! Acked-by: Kevin Hilman