From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750968AbdAMAwL (ORCPT ); Thu, 12 Jan 2017 19:52:11 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:36084 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805AbdAMAwJ (ORCPT ); Thu, 12 Jan 2017 19:52:09 -0500 From: Kevin Hilman To: Jerome Brunet Cc: Carlo Caione , linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM64: dts: meson-gxbb-odroidc2: fix GbE tx link breakage Organization: BayLibre References: <1482319894-656-1-git-send-email-jbrunet@baylibre.com> Date: Thu, 12 Jan 2017 16:52:06 -0800 In-Reply-To: <1482319894-656-1-git-send-email-jbrunet@baylibre.com> (Jerome Brunet's message of "Wed, 21 Dec 2016 12:31:34 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jerome Brunet writes: > OdroidC2 GbE link breaks under heavy tx transfer. This happens even if the > MAC does not enable Energy Efficient Ethernet (No Low Power state Idle on > the Tx path). The problem seems to come from the phy Rx path, entering the > LPI state. > > Disabling EEE advertisement on the phy prevent this feature to be > negociated with the link partner and solve the issue. > > Signed-off-by: Jerome Brunet > --- > > This patch is based on Linus recent master branch [0] > This patch depends on the series [1] which has been merged in this branch. > > 0: ba6d973f78eb ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net") > 1: http://lkml.kernel.org/r/1480326409-25419-1-git-send-email-jbrunet@baylibre.com > Fix integration of eee-broken-modes > > arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > index 238fbeacd330..d8933e9e9a5a 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > @@ -147,6 +147,18 @@ > status = "okay"; > pinctrl-0 = <ð_rgmii_pins>; > pinctrl-names = "default"; > + phy-handle = <ð_phy0>; > + > + mdio { > + compatible = "snps,dwmac-mdio"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + eth_phy0: ethernet-phy@0 { > + reg = <0>; > + eee-broken-1000t; > + }; > + }; There's already an MDIO node in the meson-gx.dtsi (using the same compatible), shouldn't you just override that and add the new properties? What would make things easier is if the names were like Martin used in his reset patch, so that when I merge them together it's not a major conflict. Thanks, Kevin [1] https://patchwork.kernel.org/patch/9459409/