From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755817AbcHBSvY (ORCPT ); Tue, 2 Aug 2016 14:51:24 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:34471 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753932AbcHBSuv (ORCPT ); Tue, 2 Aug 2016 14:50:51 -0400 From: Kevin Hilman To: Kuninori Morimoto Cc: Liam Girdwood , Mark Brown , , Sekhar Nori , Jaroslav Kysela , Takashi Iwai , open list Subject: Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() Organization: BayLibre References: <20160801233610.10479-1-khilman@baylibre.com> <877fc0hte3.wl%kuninori.morimoto.gx@renesas.com> <8760rjj20g.wl%kuninori.morimoto.gx@renesas.com> Date: Tue, 02 Aug 2016 11:50:48 -0700 In-Reply-To: <8760rjj20g.wl%kuninori.morimoto.gx@renesas.com> (Kuninori Morimoto's message of "Tue, 2 Aug 2016 03:22:08 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kuninori Morimoto writes: > From: Kuninori Morimoto > > simple-card-utils might be used as module, but MODULE_xxx() > information was missed. This patch adds it. > Otherwise, we will have below error, and can't use it. > Specil thanks to Kevin. > >> insmod simple-card-utils.ko > simple_card_utils: module license 'unspecified' taints kernel. > Disabling lock debugging due to kernel taint > simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0) > simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0) > insmod: can't insert 'simple-card-utils.ko': \ > unknown symbol in module, or unknown parameter > > Reported-by: Kevin Hilman > Signed-off-by: Kuninori Morimoto > --- > >>> Kevin > > Thank you for your report. I think this patch can solve your issue. > Can you check this ? Your patch works, but as Mark pointed out, I didn't think that this was the right fix as this isn't a module, but just library. Kevin