From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F0FCA9EAE for ; Tue, 29 Oct 2019 08:54:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8EB2B20663 for ; Tue, 29 Oct 2019 08:54:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=piap.pl header.i=@piap.pl header.b="KQJnu8OO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730091AbfJ2Iya (ORCPT ); Tue, 29 Oct 2019 04:54:30 -0400 Received: from ni.piap.pl ([195.187.100.5]:58338 "EHLO ni.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729992AbfJ2Iya (ORCPT ); Tue, 29 Oct 2019 04:54:30 -0400 Received: from t19.piap.pl (OSB1819.piap.pl [10.0.9.19]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ni.piap.pl (Postfix) with ESMTPSA id 6DA7D442258; Tue, 29 Oct 2019 09:54:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 ni.piap.pl 6DA7D442258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=piap.pl; s=mail; t=1572339264; bh=TU9ebFgfanQ7Z4iTqUkUU2jipaToSz+RUzToxJpmr6s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KQJnu8OO87rgTKcwqeO2VfIMekcbwGawgFrZFaEjV2fRRy55gzo2McuRNLzH92jr5 jK1sCYGsI7f3ncJ42fAuSZAdgoEeRQ7Sqm9C4xMXPSWOZ6rbEYBoSp8KVCCYz+yedZ x4M+UFyvwnBQQfMDU0wgJLEMSIiTg3ruAlYb9p2g= From: khalasa@piap.pl (Krzysztof =?utf-8?Q?Ha=C5=82asa?=) To: Johannes Berg Cc: "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] 802.11n IBSS: wlan0 stops receiving packets due to aggregation after sender reboot References: Date: Tue, 29 Oct 2019 09:54:24 +0100 In-Reply-To: (Johannes Berg's message of "Mon, 28 Oct 2019 13:21:15 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-KLMS-Rule-ID: 4 X-KLMS-Message-Action: skipped X-KLMS-AntiSpam-Status: not scanned, whitelist X-KLMS-AntiPhishing: not scanned, whitelist X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.721, not scanned, whitelist Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johannes Berg writes: > I think you just got very lucky (or unlucky) to have the same dialog > token, because we start from 0 Right, it seems to be the case. > - maybe we should initialize it to a > random value to flush out such issues. The problem I can see is that the dialog_tokens are 8-bit, way too small to eliminate conflicts. > Really what I think probably happened is that one of your stations lost > the connection to the other, and didn't tell it about it in any way - so > the other kept all the status alive. You must have missed my previous mail - I simply rebooted that station, and alternatively rmmoded/modprobed ath9k. But the problem originated in a station going out of and back in range, in fact. > I suspect to make all this work well we need to not only have the fixes > I made recently to actually send and parse deauth frames, but also to > even send an auth and reset the state when we receive that, so if we > move out of range and even the deauth frame is lost, we can still reset > properly. That's one thing. The other is a station trying ADDBA for the first time after boot (while the local station has seen it before that reboot). > In any case, this is not the right approach - we need to handle the > "lost connection" case better I suspect, but since you don't say what > really happened I don't really know that that's what you're seeing. I guess we need to identify "new connection" reliably. Otherwise, the new connections are treated as old ones and it doesn't work. Now how can it be fixed? --=20 Krzysztof Halasa =C5=81UKASIEWICZ Research Network Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland