From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754550AbcBPJcY (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Feb 2016 04:32:24 -0500
Received: from ni.piap.pl ([195.187.100.4]:43005 "EHLO ni.piap.pl"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752970AbcBPJcV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Feb 2016 04:32:21 -0500
From: khalasa@piap.pl (Krzysztof =?utf-8?Q?Ha=C5=82asa?=)
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        Arnd Bergmann <arnd@arndb.de>, Shawn Guo <shawnguo@kernel.org>,
        "Russell King" <linux@arm.linux.org.uk>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Hauke Mehrtens <hauke@hauke-m.de>, Rob Herring <robh+dt@kernel.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        <guohanjun@huawei.com>, Nicolas Ferre <nicolas.ferre@atmel.com>,
        Ray Jui <rjui@broadcom.com>, Lee Jones <lee@kernel.org>,
        Kukjin Kim <kgene@kernel.org>, Rob Herring <robh@kernel.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        Roland Stigge <stigge@antcom.de>, Jason Cooper <jason@lakedaemon.net>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        "Heiko Stuebner" <heiko@sntech.de>, Viresh Kumar <vireshk@kernel.org>,
        Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
        Tony Prisk <linux@prisktech.co.nz>
Subject: Re: [PATCH v2 01/15] arm: use of_platform_default_populate() to populate default bus
References: <1453868872-26300-2-git-send-email-wangkefeng.wang@huawei.com>
	<1453881180-12296-1-git-send-email-wangkefeng.wang@huawei.com>
Date: Tue, 16 Feb 2016 10:32:17 +0100
In-Reply-To: <1453881180-12296-1-git-send-email-wangkefeng.wang@huawei.com>
	(Kefeng Wang's message of "Wed, 27 Jan 2016 15:53:00 +0800")
Message-ID: <m38u2lq9um.fsf@t19.piap.pl>
MIME-Version: 1.0
Content-Type: text/plain
X-KLMS-Rule-ID: 1
X-KLMS-Message-Action: clean
X-KLMS-AntiSpam-Lua-Profiles: 91383 [Feb 16 2016]
X-KLMS-AntiSpam-Version: 5.5.9.33
X-KLMS-AntiSpam-Envelope-From: khalasa@piap.pl
X-KLMS-AntiSpam-Rate: 0
X-KLMS-AntiSpam-Status: not_detected
X-KLMS-AntiSpam-Method: none
X-KLMS-AntiSpam-Moebius-Timestamps: 3964759, 3964785, 3964653
X-KLMS-AntiSpam-Info: LuaCore: 412 412 4b6b6fc5d3af82f77698bd9ab71b5a4bf748b220, Auth:dkim=none
X-KLMS-AntiSpam-Interceptor-Info: scan successful
X-KLMS-AntiPhishing: Clean, 2016/02/15 14:33:11
X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.721, bases: 2016/02/16 02:23:00 #7171312
X-KLMS-AntiVirus-Status: Clean, skipped
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Kefeng Wang <wangkefeng.wang@huawei.com> writes:

> Use helper of_platform_default_populate() in linux/of_platform
> when possible, instead of calling of_platform_populate() with
> the default match table.
> --- a/arch/arm/mach-cns3xxx/core.c
> +++ b/arch/arm/mach-cns3xxx/core.c
> @@ -395,8 +395,7 @@ static void __init cns3xxx_init(void)
>  
>  	pm_power_off = cns3xxx_power_off;
>  
> -	of_platform_populate(NULL, of_default_bus_match_table,
> -                        cns3xxx_auxdata, NULL);
> +	of_platform_default_populate(NULL, cns3xxx_auxdata, NULL);
>  }
>  

Doesn't look wrong :-)

Acked-by: Krzysztof Halasa <khalasa@piap.pl>

-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland