From: James Cloos <cloos@jhcloos.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: Linux 3.13-rc1 is out
Date: Fri, 22 Nov 2013 19:51:18 -0500 [thread overview]
Message-ID: <m3li0gndnk.fsf@carbon.jhcloos.org> (raw)
In-Reply-To: <CA+55aFxK5hkhteiL5cyPtHX5reup6aOiHQTCDKKdBsHiWsroGA@mail.gmail.com> (Linus Torvalds's message of "Fri, 22 Nov 2013 12:36:37 -0800")
This combination:
# CONFIG_SYSTEM_TRUSTED_KEYRING is not set
CONFIG_TRUSTED_KEYS=m
(acquired by oldconfig and N to system keyring)
fails with:
Pass 2
CC [M] crypto/asymmetric_keys/x509_rsakey-asn1.o
CC [M] crypto/asymmetric_keys/x509_cert_parser.o
CC [M] crypto/asymmetric_keys/x509_public_key.o
crypto/asymmetric_keys/x509_public_key.c: In function ‘x509_key_preparse’:
crypto/asymmetric_keys/x509_public_key.c:237:35: error: ‘system_trusted_keyring’ undeclared (first use in this function)
ret = x509_validate_trust(cert, system_trusted_keyring);
^
crypto/asymmetric_keys/x509_public_key.c:237:35: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [crypto/asymmetric_keys/x509_public_key.o] Error 1
make[1]: *** [crypto/asymmetric_keys] Error 2
make: *** [crypto] Error 2
Perhaps include/keys/system_keyring.h should have a definition for
system_trusted_keyring in the #ifndef CONFIG_SYSTEM_TRUSTED_KEYRING
case (which may entail just removing the #ifdef).
Commits b56e5a17b6b9acd1 and 09fbc47373826d67 are relevant.
-JimC
--
James Cloos <cloos@jhcloos.com> OpenPGP: 1024D/ED7DAEA6
next prev parent reply other threads:[~2013-11-23 1:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 20:36 Linux 3.13-rc1 is out Linus Torvalds
2013-11-23 0:43 ` Matthew Garrett
2013-11-23 1:08 ` Linus Torvalds
2013-11-23 0:51 ` James Cloos [this message]
2013-11-23 2:32 ` Jongman Heo
2013-11-23 0:58 ` Shuah Khan
2013-11-25 0:10 ` linux-next stats (Was: Linux 3.13-rc1 is out) Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3li0gndnk.fsf@carbon.jhcloos.org \
--to=cloos@jhcloos.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).