linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] Smarter stack traces using the frame pointer
Date: Mon, 10 Nov 2003 19:06:03 +0100	[thread overview]
Message-ID: <m3wua85cac.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <QouH.36G.7@gated-at.bofh.it> (Adam Litke's message of "Mon, 10 Nov 2003 19:00:15 +0100")

Adam Litke <agl@us.ibm.com> writes:

> -static int kstack_depth_to_print = 24;
> +static int kstack_depth_to_print = 128;

I would not do that. It makes too much of the oops scroll away.

> +	show_stack_frame((unsigned long) stack, ebp+4);

I think this needs much more sanity checking, otherwise the risk
of recursive oops etc is too big.

I would always check first if the stack value read from ebp is inside the 
stack page of the current process. If you're paranoid you could even use 
__get_user() to catch exceptions.

-Andi

       reply	other threads:[~2003-11-10 18:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <OhH5.6Y2.13@gated-at.bofh.it>
     [not found] ` <QouH.36G.7@gated-at.bofh.it>
2003-11-10 18:06   ` Andi Kleen [this message]
2003-11-06 20:08 [RFC] Smarter stack traces using the frame pointer Dan Kegel
  -- strict thread matches above, loose matches on Subject: below --
2003-11-04 22:13 Adam Litke
2003-11-05  2:21 ` Stephen Rothwell
2003-11-05 19:56   ` Martin J. Bligh
2003-11-06 11:51     ` Stephen Rothwell
2003-11-06 15:21       ` Martin J. Bligh
2003-11-10 17:46 ` Adam Litke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3wua85cac.fsf@averell.firstfloor.org \
    --to=ak@muc.de \
    --cc=agl@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).