linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] riscv: Fixed kernel test robot warning
@ 2020-12-08 19:27 Souptick Joarder
  2020-12-08 19:51 ` Andreas Schwab
  0 siblings, 1 reply; 5+ messages in thread
From: Souptick Joarder @ 2020-12-08 19:27 UTC (permalink / raw)
  To: paul.walmsley, palmer, aou, guoren
  Cc: linux-riscv, linux-kernel, Souptick Joarder

Kernel test robot throws below warning -

   arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
for 'asm_offsets' [-Wmissing-prototypes]
      14 | void asm_offsets(void)
         |      ^~~~~~~~~~~

This patch should fixed it.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 arch/riscv/kernel/asm-offsets.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/riscv/kernel/asm-offsets.c b/arch/riscv/kernel/asm-offsets.c
index db20344..b79ffa3 100644
--- a/arch/riscv/kernel/asm-offsets.c
+++ b/arch/riscv/kernel/asm-offsets.c
@@ -11,6 +11,8 @@
 #include <asm/thread_info.h>
 #include <asm/ptrace.h>
 
+void asm_offsets(void);
+
 void asm_offsets(void)
 {
 	OFFSET(TASK_THREAD_RA, task_struct, thread.ra);
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] riscv: Fixed kernel test robot warning
  2020-12-08 19:27 [PATCH] riscv: Fixed kernel test robot warning Souptick Joarder
@ 2020-12-08 19:51 ` Andreas Schwab
  2020-12-08 19:58   ` Souptick Joarder
  0 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2020-12-08 19:51 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: paul.walmsley, palmer, aou, guoren, linux-riscv, linux-kernel

On Dez 09 2020, Souptick Joarder wrote:

> Kernel test robot throws below warning -
>
>    arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
> for 'asm_offsets' [-Wmissing-prototypes]
>       14 | void asm_offsets(void)
>          |      ^~~~~~~~~~~
>
> This patch should fixed it.

Or rename it to main, like most other asm-offsets files.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] riscv: Fixed kernel test robot warning
  2020-12-08 19:51 ` Andreas Schwab
@ 2020-12-08 19:58   ` Souptick Joarder
  2020-12-08 20:22     ` Andreas Schwab
  0 siblings, 1 reply; 5+ messages in thread
From: Souptick Joarder @ 2020-12-08 19:58 UTC (permalink / raw)
  To: Andreas Schwab
  Cc: paul.walmsley, palmer, aou, guoren, linux-riscv, linux-kernel

On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Dez 09 2020, Souptick Joarder wrote:
>
> > Kernel test robot throws below warning -
> >
> >    arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
> > for 'asm_offsets' [-Wmissing-prototypes]
> >       14 | void asm_offsets(void)
> >          |      ^~~~~~~~~~~
> >
> > This patch should fixed it.
>
> Or rename it to main, like most other asm-offsets files.

Few asm-offsets files named it as foo(). Does a rename to main() will
work straight forward ?
I don't know much about this area of code.

>
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
> "And now for something completely different."

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] riscv: Fixed kernel test robot warning
  2020-12-08 19:58   ` Souptick Joarder
@ 2020-12-08 20:22     ` Andreas Schwab
  2020-12-11  1:47       ` Palmer Dabbelt
  0 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2020-12-08 20:22 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: paul.walmsley, palmer, aou, guoren, linux-riscv, linux-kernel

On Dez 09 2020, Souptick Joarder wrote:

> On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>>
>> On Dez 09 2020, Souptick Joarder wrote:
>>
>> > Kernel test robot throws below warning -
>> >
>> >    arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
>> > for 'asm_offsets' [-Wmissing-prototypes]
>> >       14 | void asm_offsets(void)
>> >          |      ^~~~~~~~~~~
>> >
>> > This patch should fixed it.
>>
>> Or rename it to main, like most other asm-offsets files.
>
> Few asm-offsets files named it as foo(). Does a rename to main() will
> work straight forward ?

Calling it main will suppress the warning, but other than that it is
completely irrelevant how you call it.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] riscv: Fixed kernel test robot warning
  2020-12-08 20:22     ` Andreas Schwab
@ 2020-12-11  1:47       ` Palmer Dabbelt
  0 siblings, 0 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2020-12-11  1:47 UTC (permalink / raw)
  To: schwab; +Cc: jrdr.linux, Paul Walmsley, aou, guoren, linux-riscv, linux-kernel

On Tue, 08 Dec 2020 12:22:46 PST (-0800), schwab@linux-m68k.org wrote:
> On Dez 09 2020, Souptick Joarder wrote:
>
>> On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>>>
>>> On Dez 09 2020, Souptick Joarder wrote:
>>>
>>> > Kernel test robot throws below warning -
>>> >
>>> >    arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
>>> > for 'asm_offsets' [-Wmissing-prototypes]
>>> >       14 | void asm_offsets(void)
>>> >          |      ^~~~~~~~~~~
>>> >
>>> > This patch should fixed it.
>>>
>>> Or rename it to main, like most other asm-offsets files.
>>
>> Few asm-offsets files named it as foo(). Does a rename to main() will
>> work straight forward ?
>
> Calling it main will suppress the warning, but other than that it is
> completely irrelevant how you call it.

Ya, I think it doesn't really matter so I'm just going to take this as is.
It's on for-next (being a bit paranoid, as we're so late in the cycle).

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-12-11  1:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-08 19:27 [PATCH] riscv: Fixed kernel test robot warning Souptick Joarder
2020-12-08 19:51 ` Andreas Schwab
2020-12-08 19:58   ` Souptick Joarder
2020-12-08 20:22     ` Andreas Schwab
2020-12-11  1:47       ` Palmer Dabbelt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).