From: Palmer Dabbelt <palmer@sifive.com>
To: ldv@altlinux.org
Cc: luto@kernel.org, lineprinter@altlinux.org,
david.abdurachmanov@gmail.com, aou@eecs.berkeley.edu,
paul@paul-moore.com, eparis@redhat.com,
linux-riscv@lists.infradead.org, linux-audit@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/13 v2] riscv: define syscall_get_arch()
Date: Sun, 11 Nov 2018 13:21:24 -0800 (PST) [thread overview]
Message-ID: <mhng-11f5dbf6-0aee-4f6e-b184-63536ecc3ac5@palmer-si-x1c4> (raw)
In-Reply-To: <20181109224833.GA2710@altlinux.org>
On Fri, 09 Nov 2018 14:48:33 PST (-0800), ldv@altlinux.org wrote:
> syscall_get_arch() is required to be implemented on all architectures
> that use tracehook_report_syscall_entry() in order to extend
> the generic ptrace API with PTRACE_GET_SYSCALL_INFO request.
>
> Based-on-patch-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> ---
> arch/riscv/include/asm/syscall.h | 10 ++++++++++
> include/uapi/linux/audit.h | 2 ++
> 2 files changed, 12 insertions(+)
>
> diff --git a/arch/riscv/include/asm/syscall.h b/arch/riscv/include/asm/syscall.h
> index 8d25f8904c00..bba3da6ef157 100644
> --- a/arch/riscv/include/asm/syscall.h
> +++ b/arch/riscv/include/asm/syscall.h
> @@ -18,6 +18,7 @@
> #ifndef _ASM_RISCV_SYSCALL_H
> #define _ASM_RISCV_SYSCALL_H
>
> +#include <uapi/linux/audit.h>
> #include <linux/sched.h>
> #include <linux/err.h>
>
> @@ -99,4 +100,13 @@ static inline void syscall_set_arguments(struct task_struct *task,
> memcpy(®s->a1 + i * sizeof(regs->a1), args, n * sizeof(regs->a0));
> }
>
> +static inline int syscall_get_arch(void)
> +{
> +#ifdef CONFIG_64BIT
> + return AUDIT_ARCH_RISCV64;
> +#else
> + return AUDIT_ARCH_RISCV32;
> +#endif
> +}
> +
> #endif /* _ASM_RISCV_SYSCALL_H */
> diff --git a/include/uapi/linux/audit.h b/include/uapi/linux/audit.h
> index c4c8b131af48..1b199a77a6b9 100644
> --- a/include/uapi/linux/audit.h
> +++ b/include/uapi/linux/audit.h
> @@ -405,6 +405,8 @@ enum {
> /* do not define AUDIT_ARCH_PPCLE since it is not supported by audit */
> #define AUDIT_ARCH_PPC64 (EM_PPC64|__AUDIT_ARCH_64BIT)
> #define AUDIT_ARCH_PPC64LE (EM_PPC64|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE)
> +#define AUDIT_ARCH_RISCV32 (EM_RISCV|__AUDIT_ARCH_LE)
> +#define AUDIT_ARCH_RISCV64 (EM_RISCV|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE)
> #define AUDIT_ARCH_S390 (EM_S390)
> #define AUDIT_ARCH_S390X (EM_S390|__AUDIT_ARCH_64BIT)
> #define AUDIT_ARCH_SH (EM_SH)
Reviewed-by: Palmer Dabbelt <palmer@sifive.com>
Thanks!
next prev parent reply other threads:[~2018-11-11 21:21 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 3:27 [RFC PATCH] ptrace: add PTRACE_GET_SYSCALL_INFO request Elvira Khabirova
2018-11-07 11:21 ` Oleg Nesterov
2018-11-07 14:06 ` Andy Lutomirski
2018-11-07 16:44 ` Oleg Nesterov
2018-11-07 20:02 ` Elvira Khabirova
2018-11-08 9:16 ` Oleg Nesterov
2018-11-07 20:20 ` Andy Lutomirski
2018-11-08 14:33 ` Oleg Nesterov
2018-11-07 16:12 ` Dmitry V. Levin
2018-11-07 15:50 ` Dmitry V. Levin
2018-11-07 20:44 ` Andy Lutomirski
2018-11-09 3:13 ` [PATCH 00/13] Prepare for PTRACE_GET_SYSCALL_INFO Dmitry V. Levin
2018-11-09 3:15 ` [PATCH 01/13] Move EM_HEXAGON to uapi/linux/elf-em.h Dmitry V. Levin
2018-11-09 3:15 ` [PATCH 02/13] elf-em.h: add EM_ARC Dmitry V. Levin
2018-11-09 14:20 ` Alexey Brodkin
2018-11-09 16:41 ` Vineet Gupta
2018-11-09 21:44 ` Dmitry V. Levin
2018-11-09 23:33 ` [PATCH 02/13 v2] Move EM_ARCOMPACT and EM_ARCV2 to uapi/linux/elf-em.h Dmitry V. Levin
2018-11-09 23:42 ` Vineet Gupta
2018-11-09 3:15 ` [PATCH 03/13] elf-em.h: add EM_NDS32 Dmitry V. Levin
2018-11-09 3:15 ` [PATCH 04/13] elf-em.h: add EM_XTENSA Dmitry V. Levin
2018-11-09 6:45 ` Max Filippov
2018-11-09 3:15 ` [PATCH 05/13] m68k: define syscall_get_arch() Dmitry V. Levin
2018-11-09 3:16 ` [PATCH 06/13] arc: " Dmitry V. Levin
2018-11-09 14:22 ` Alexey Brodkin
2018-11-09 15:17 ` Andy Lutomirski
2018-11-09 15:27 ` Alexey Brodkin
2018-11-09 15:56 ` Andy Lutomirski
2018-11-09 16:11 ` Alexey Brodkin
2018-11-09 16:35 ` Andy Lutomirski
2018-11-09 23:33 ` [PATCH 06/13 v2] " Dmitry V. Levin
2018-11-09 23:39 ` Vineet Gupta
2018-11-09 23:54 ` [PATCH 06/13 v3] " Dmitry V. Levin
2018-11-10 0:06 ` Vineet Gupta
2018-11-09 16:50 ` [PATCH 06/13] " Vineet Gupta
2018-11-09 19:03 ` Andy Lutomirski
2018-11-09 19:13 ` Vineet Gupta
2018-11-09 3:16 ` [PATCH 07/13] c6x: " Dmitry V. Levin
2018-11-10 2:01 ` [PATCH 07/13 v2] " Dmitry V. Levin
2018-11-09 3:16 ` [PATCH 08/13] h8300: " Dmitry V. Levin
2018-11-09 3:16 ` [PATCH 09/13] hexagon: " Dmitry V. Levin
2018-11-09 3:16 ` [PATCH 10/13] nds32: " Dmitry V. Levin
2018-11-10 2:01 ` [PATCH 10/13 v2] " Dmitry V. Levin
2018-11-09 3:17 ` [PATCH 11/13] nios2: " Dmitry V. Levin
2018-11-09 3:17 ` [PATCH 12/13] riscv: " Dmitry V. Levin
2018-11-09 6:59 ` David Abdurachmanov
2018-11-09 22:28 ` Dmitry V. Levin
2018-11-10 5:12 ` David Abdurachmanov
2018-11-10 9:27 ` Andreas Schwab
2018-11-09 18:45 ` Palmer Dabbelt
2018-11-09 21:31 ` Dmitry V. Levin
2018-11-09 22:48 ` [PATCH 12/13 v2] " Dmitry V. Levin
2018-11-11 21:21 ` Palmer Dabbelt [this message]
2018-11-09 3:17 ` [PATCH 13/13] xtensa: " Dmitry V. Levin
2018-11-09 6:48 ` Max Filippov
2018-11-09 6:06 ` [PATCH 00/13] Prepare for PTRACE_GET_SYSCALL_INFO Andy Lutomirski
2018-11-10 14:09 ` [PATCH 14/13] Move EM_UNICORE to uapi/linux/elf-em.h Dmitry V. Levin
2018-11-10 14:10 ` [PATCH 15/13] unicore32: define syscall_get_arch() Dmitry V. Levin
2018-11-13 3:38 ` [RFC PATCH] ptrace: add PTRACE_GET_SYSCALL_INFO request Dmitry V. Levin
2018-11-20 0:11 ` [PATCH v2 00/15] Prepare for PTRACE_GET_SYSCALL_INFO Dmitry V. Levin
2018-11-20 0:14 ` [PATCH v2 01/15] Move EM_HEXAGON to uapi/linux/elf-em.h Dmitry V. Levin
2018-11-20 0:14 ` [PATCH v2 02/15] Move EM_ARCOMPACT and EM_ARCV2 " Dmitry V. Levin
2018-11-20 0:14 ` [PATCH v2 03/15] Move EM_UNICORE " Dmitry V. Levin
2018-11-20 0:15 ` [PATCH v2 04/15] elf-em.h: add EM_NDS32 Dmitry V. Levin
2018-11-20 0:15 ` [PATCH v2 05/15] elf-em.h: add EM_XTENSA Dmitry V. Levin
2018-11-20 0:15 ` [PATCH v2 06/15] m68k: define syscall_get_arch() Dmitry V. Levin
2018-12-02 10:29 ` Geert Uytterhoeven
2018-12-03 0:24 ` Dmitry V. Levin
2018-12-03 7:36 ` Geert Uytterhoeven
2018-11-20 0:15 ` [PATCH v2 07/15] arc: " Dmitry V. Levin
2018-11-20 0:15 ` [PATCH v2 08/15] c6x: " Dmitry V. Levin
2018-11-20 0:16 ` [PATCH v2 09/15] h8300: " Dmitry V. Levin
2018-11-20 0:16 ` [PATCH v2 10/15] hexagon: " Dmitry V. Levin
2018-11-20 0:16 ` [PATCH v2 11/15] nds32: " Dmitry V. Levin
2018-11-20 0:16 ` [PATCH v2 12/15] nios2: " Dmitry V. Levin
2018-11-20 0:16 ` [PATCH v2 13/15] riscv: " Dmitry V. Levin
2018-11-20 0:16 ` [PATCH v2 14/15] unicore32: " Dmitry V. Levin
2018-11-20 0:17 ` [PATCH v2 15/15] xtensa: " Dmitry V. Levin
2018-11-20 20:26 ` [PATCH v2 00/15] Prepare for PTRACE_GET_SYSCALL_INFO Paul Moore
[not found] ` <20181121004422.GA29053@altlinux.org>
[not found] ` <20181121184004.jro532jopnbmru2m@pburton-laptop>
2018-11-21 19:00 ` [PATCH v2 16/15] syscall_get_arch: add "struct task_struct *" argument Dmitry V. Levin
2018-11-21 19:14 ` [PATCH] mips: fix mips_get_syscall_arg o32 check Dmitry V. Levin
2018-11-21 19:23 ` Paul Burton
2018-11-21 19:35 ` [PATCH v2 16/15 v2] syscall_get_arch: add "struct task_struct *" argument Dmitry V. Levin
2018-11-21 19:45 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-11f5dbf6-0aee-4f6e-b184-63536ecc3ac5@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=david.abdurachmanov@gmail.com \
--cc=eparis@redhat.com \
--cc=ldv@altlinux.org \
--cc=lineprinter@altlinux.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=luto@kernel.org \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).