From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EEA4ECDE43 for ; Fri, 19 Oct 2018 18:18:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D6F2B2087A for ; Fri, 19 Oct 2018 18:18:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="T5bqeL5L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6F2B2087A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727613AbeJTCZf (ORCPT ); Fri, 19 Oct 2018 22:25:35 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:41947 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727410AbeJTCZf (ORCPT ); Fri, 19 Oct 2018 22:25:35 -0400 Received: by mail-pg1-f196.google.com with SMTP id 23-v6so16094078pgc.8 for ; Fri, 19 Oct 2018 11:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=nmeckNFphp/x15aPxZY+QfLLPrluX8Ha3iNeceCHXR0=; b=T5bqeL5LfyW6P8gqFxda7vnjy6IAxOqPyFkv0PgB5x/+Qu7ZfuV3o3xTckTa9V7j2G jF6wwHddEDCK+1JLYoYg+udap+i4lWOA7klTDzmnGkfnebOjG6We5MAhTvm4VzVmdePH 6sarJYOZ8BnDIJT2GW5ap+HewSnzP1LQlRMh7GPPw2cvXoUxFpVkksIJQeiWfeaRGduz pW1ZEIF133SYZFttuxW+RPkYBReeIujsNcqMSIcSjQzKB9uYQLjCOKDcISJojMpPuzi3 dOegDod43mpUiqUfB7mi34SZ7/GlljCYAAd/pL+U9XYwz5ycYIivUIjWqeoics9ga0LT W8lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=nmeckNFphp/x15aPxZY+QfLLPrluX8Ha3iNeceCHXR0=; b=hoNd7tJlRqn9y6NOMRnzvEJMrUj68puPEARIul3bH6oKUW+83OzjzMZ6ZVfY2Mwkx4 E+mK0hWijMdOTIvrQUXgf4t5ItbYqbz6plIc3CrSJt4hmLUQbdw/XUcsJ7txw9WaUg1R uJu3x4ffN+Eu0I3MgIQJs2mbccUq817UfrqF2ZE3M3u5eK7SyrORkrdH8QIG7TFtRJdk FLYYdET9eUek7nntMdFzYhM0MWK3O+jkTkBQm3S85r/tK2fEhptrdjvnkCfOQNpq5rMf lwAdv66YjSEw84JI/kqWC/oeQGGFxA87M28Y648YXbNN+T81+HDASPv/ZwVvjhxCGV83 WFww== X-Gm-Message-State: ABuFfoiRs9nq9DnGPHs2C8nOidCIyevynMTUKGmqdXMA7m6DNAOjsPu7 Zf5DH2j+xAetFODhwPr8oWRTuQ== X-Google-Smtp-Source: ACcGV60hu30sK8WGsyOOmc9OyGfiaulMhF1Tfiwp1vHNedYePnQLmlk7+2KpKHMdD2AVMwNv7Bt44A== X-Received: by 2002:a63:3c46:: with SMTP id i6-v6mr33222663pgn.286.1539973103049; Fri, 19 Oct 2018 11:18:23 -0700 (PDT) Received: from localhost ([12.206.222.5]) by smtp.gmail.com with ESMTPSA id e3-v6sm31153305pgc.71.2018.10.19.11.18.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Oct 2018 11:18:22 -0700 (PDT) Date: Fri, 19 Oct 2018 11:18:22 -0700 (PDT) X-Google-Original-Date: Fri, 19 Oct 2018 11:11:52 PDT (-0700) Subject: Re: [PATCH 6/9] PCI: consolidate PCI config entry in drivers/pci In-Reply-To: <20181019120952.32763-7-hch@lst.de> CC: yamada.masahiro@socionext.com, mporter@kernel.crashing.org, alex.bou9@gmail.com, linux@dominikbrodowski.net, linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org From: Palmer Dabbelt To: Christoph Hellwig Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 Oct 2018 05:09:49 PDT (-0700), Christoph Hellwig wrote: > There is no good reason to duplicate the PCI menu in every architecture. > Instead provide a selectable HAVE_PCI symbol that indicates availability > of PCI support and the handle the rest in drivers/pci. > > Note that for powerpc we now select HAVE_PCI globally instead of the > convoluted mess of conditional or or non-conditional support per board, > similar to what we do e.g. on x86. For alpha PCI is selected for the > non-jensen configs as it was the default before, and a lot of code does > not compile without PCI enabled. On other architectures with limited > PCI support that wasn't as complicated I've left the selection as-is. > > Signed-off-by: Christoph Hellwig > Acked-by: Max Filippov > Acked-by: Thomas Gleixner > Acked-by: Bjorn Helgaas ... > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index a344980287a5..071952cd4cae 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -39,8 +39,10 @@ config RISCV > select SPARSE_IRQ > select SYSCTL_EXCEPTION_TRACE > select HAVE_ARCH_TRACEHOOK > + select HAVE_PCI > select MODULES_USE_ELF_RELA if MODULES > select THREAD_INFO_IN_TASK > + select PCI_MSI if PCI > select RISCV_TIMER > select GENERIC_IRQ_MULTI_HANDLER > select ARCH_HAS_PTE_SPECIAL > @@ -216,28 +218,12 @@ source "kernel/Kconfig.hz" > > endmenu > > -menu "Bus support" > - > -config PCI > - bool "PCI support" > - select PCI_MSI > - help > - This feature enables support for PCI bus system. If you say Y > - here, the kernel will include drivers and infrastructure code > - to support PCI bus devices. > - > - If you don't know what to do here, say Y. > - > config PCI_DOMAINS > def_bool PCI > > config PCI_DOMAINS_GENERIC > def_bool PCI > > -source "drivers/pci/Kconfig" > - > -endmenu > - > menu "Power management options" > > source kernel/power/Kconfig Reviewed-by: Palmer Dabbelt I'm assuming this will go in via PCI tree of some sort, so I'm not going to touch it any further. Thanks for cleaning this up!