From: Palmer Dabbelt <palmer@sifive.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: aou@eecs.berkeley.edu, Andrew Waterman <andrew@sifive.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux@dominikbrodowski.net,
Christoph Hellwig <hch@infradead.org>,
dan.carpenter@oracle.com, tklauser@distanz.ch,
linux-riscv@lists.infradead.org, linux@roeck-us.net
Subject: Re: [PATCH v3 1/2] RISC-V: Define sys_riscv_flush_icache when SMP=n
Date: Fri, 10 Aug 2018 11:27:37 -0700 (PDT) [thread overview]
Message-ID: <mhng-341b5b76-2cd6-41e3-859a-6b1d926ba770@palmer-si-x1c4> (raw)
In-Reply-To: <20180810083804.GA20415@infradead.org>
On Fri, 10 Aug 2018 01:38:04 PDT (-0700), Christoph Hellwig wrote:
> On Thu, Aug 09, 2018 at 03:19:51PM -0700, Palmer Dabbelt wrote:
>> This would be necessary to make non-SMP builds work, but there is
>> another error in the implementation of our syscall linkage that actually
>> just causes sys_riscv_flush_icache to never build. I've build tested
>> this on allnoconfig and allnoconfig+SMP=y, as well as defconfig like
>> normal.
>
> Would't it make sense to use COND_SYSCALL to stub out the syscall
> for !SMP builds?
I'm not sure. We can implement the syscall fine in !SMP, it's just that the
vDSO is expected to always eat these calls because in non-SMP mode you can do a
global fence.i by just doing a local fence.i (there's only one hart).
The original rationale behind not having the syscall in non-SMP mode was to
limit the user ABI, but on looking again that seems like it's just a bit of
extra complexity that doesn't help anything. It's already been demonstrated
that nothing is checking the error because it's been silently slipping past
userspace for six months, so the extra complexity seems like it'll just cause
someone else to have to chase the bug in the future.
But I'm really OK either way. Is there a precedent for what to do here?
next prev parent reply other threads:[~2018-08-10 18:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 22:19 RISC-V: Don't use a global include guard for uapi/asm/syscalls Palmer Dabbelt
2018-08-09 22:19 ` [PATCH v3 1/2] RISC-V: Define sys_riscv_flush_icache when SMP=n Palmer Dabbelt
2018-08-10 8:38 ` Christoph Hellwig
2018-08-10 18:27 ` Palmer Dabbelt [this message]
2018-08-10 18:47 ` Guenter Roeck
2018-08-10 20:55 ` Palmer Dabbelt
2018-08-14 13:35 ` Christoph Hellwig
2018-08-10 14:07 ` Guenter Roeck
2018-08-14 13:39 ` Christoph Hellwig
2018-08-20 23:30 ` Palmer Dabbelt
2018-08-09 22:19 ` [PATCH v3 2/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h Palmer Dabbelt
2018-08-10 14:07 ` Guenter Roeck
2018-08-14 13:40 ` Christoph Hellwig
2018-08-20 23:30 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-341b5b76-2cd6-41e3-859a-6b1d926ba770@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=andrew@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@dominikbrodowski.net \
--cc=linux@roeck-us.net \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).