From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751569AbdFFUiY (ORCPT ); Tue, 6 Jun 2017 16:38:24 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35397 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbdFFUiC (ORCPT ); Tue, 6 Jun 2017 16:38:02 -0400 Date: Tue, 06 Jun 2017 13:38:01 -0700 (PDT) X-Google-Original-Date: Tue, 06 Jun 2017 12:16:00 PDT (-0700) From: Palmer Dabbelt To: Arnd Bergmann CC: olof@lixom.net CC: linux-kernel@vger.kernel.org CC: albert@sifive.com Subject: Re: [PATCH 6/7] RISC-V: arch/riscv/kernel In-Reply-To: Message-ID: Mime-Version: 1.0 (MHng) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 06 Jun 2017 02:03:51 PDT (-0700), Arnd Bergmann wrote: > On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt wrote: >> On Thu, 25 May 2017 12:51:54 PDT (-0700), Arnd Bergmann wrote: >>> On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: >>>> On Mon, 22 May 2017 19:11:35 PDT (-0700), olof@lixom.net wrote: >>> >>>> * Definitions like ARCH_HAS_SETUP_ADDITIONAL_PAGES, these are also present in >>>> other architectures. >>> >>> What is the warning here? I would assume that you should leave this >>> unchanged as well. >> >> ERROR: #define of 'ARCH_HAS_SETUP_ADDITIONAL_PAGES' is wrong - use Kconfig variables or standard guards instead >> #2533: FILE: arch/riscv/include/asm/elf.h:79: >> +#define ARCH_HAS_SETUP_ADDITIONAL_PAGES > > Ok, you can definitely ignore this one. The warning is meant to prevent adding > new macros like that, but the macro already exists in the other architectures, > and I see no point in converting them all into a CONFIG_ symbol. Sounds good.