From: Palmer Dabbelt <palmer@sifive.com>
To: alankao@andestech.com
Cc: linux@roeck-us.net, zong@andestech.com, nickhu@andestech.com,
greentime@andestech.com, linux-kernel@vger.kernel.org,
vincentc@andestech.com, linux-riscv@lists.infradead.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v8 3/5] Cleanup ISA string setting
Date: Mon, 15 Oct 2018 15:34:18 -0700 (PDT) [thread overview]
Message-ID: <mhng-48e07863-dd56-4ef6-8342-aa19414bc1b8@palmer-si-x1c4> (raw)
In-Reply-To: <20181014234639.GA14835@andestech.com>
On Sun, 14 Oct 2018 16:46:40 PDT (-0700), alankao@andestech.com wrote:
> Hi Guenter,
>
> On Sat, Oct 13, 2018 at 05:02:05PM -0700, Guenter Roeck wrote:
>> Hi,
>>
>> With this patch in -next applied, I get the following error
>> when building riscv:defconfig.
>
> I guess what you meant was this commit:
> commit 0a5bee05fc67ce2044b8d91a18abbf14042da531
>
> The modification in Makefile was
>
> -endif
> -
> -KBUILD_AFLAGS += -march=$(KBUILD_MARCH)$(KBUILD_ARCH_A)fd$(KBUILD_ARCH_C)
> +# ISA string setting
> +riscv-march-$(CONFIG_ARCH_RV32I) := rv32im
> +riscv-march-$(CONFIG_ARCH_RV64I) := rv64im
> +riscv-march-$(CONFIG_RISCV_ISA_A) := $(riscv-march-y)a
> +riscv-march-y := fd
> +riscv-march-$(CONFIG_RISCV_ISA_C) := $(riscv-march-y)c
>
> and the ":= fd" line was wrong. It should have been
>
> +riscv-march-y := $(riscv-march-y)fd
>
>>
>>
>> What am I missing ? Does RISC-V now require a new non-upstream compiler ?
>> Or a special version of make ? I am currently using GNU Make 4.1.
>
> So I sent the v8 to fix this problem.
> Sorry for the inconvinience.
>
>>
>> Thanks,
>> Guenter
>>
>> ---
>
> And Palmer, it seems that the patch that causes this build error has been
> pulled into linux-next. Any idea how to fix that one?
If I run into the new version then I'll overwrite in in my for-next branch. I
don't see one, though...
next prev parent reply other threads:[~2018-10-15 22:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 2:18 [PATCH v8 0/5] riscv: Add support to no-FPU systems Alan Kao
2018-10-09 2:18 ` [PATCH v8 1/5] Extract FPU context operations from entry.S Alan Kao
2018-10-09 2:18 ` [PATCH v8 2/5] Refactor FPU code in signal setup/return procedures Alan Kao
2018-10-09 2:18 ` [PATCH v8 3/5] Cleanup ISA string setting Alan Kao
2018-10-14 0:02 ` Guenter Roeck
2018-10-14 23:46 ` Alan Kao
2018-10-15 2:13 ` Guenter Roeck
2018-10-15 22:34 ` Palmer Dabbelt [this message]
2018-10-16 13:18 ` Guenter Roeck
2018-10-09 2:18 ` [PATCH v8 4/5] Allow to disable FPU support Alan Kao
2018-10-09 2:18 ` [PATCH v8 5/5] Auto-detect whether a FPU exists Alan Kao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-48e07863-dd56-4ef6-8342-aa19414bc1b8@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=alankao@andestech.com \
--cc=greentime@andestech.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=nickhu@andestech.com \
--cc=vincentc@andestech.com \
--cc=zong@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).