From: Palmer Dabbelt <palmer@dabbelt.com>
To: Atish Patra <Atish.Patra@wdc.com>
Cc: linux-kernel@vger.kernel.org, Atish Patra <Atish.Patra@wdc.com>,
ardb@kernel.org, linux-efi@vger.kernel.org,
linux-riscv@lists.infradead.org, masahiroy@kernel.org,
xypron.glpk@gmx.de
Subject: Re: [v4 PATCH 1/3] RISC-V: Define fixmap bindings for generic early ioremap support
Date: Tue, 21 Apr 2020 12:52:05 -0700 (PDT) [thread overview]
Message-ID: <mhng-613ec31b-83df-4a01-998c-e2d682787c1b@palmerdabbelt-glaptop1> (raw)
In-Reply-To: <20200421033336.9663-2-atish.patra@wdc.com>
I missed that there's a v4 now, so I'm jumping over here
On Mon, 20 Apr 2020 20:33:34 PDT (-0700), Atish Patra wrote:
> UEFI uses early IO or memory mappings for runtime services before
> normal ioremap() is usable. This patch only adds minimum necessary
> fixmap bindings and headers for generic ioremap support to work.
>
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/riscv/Kconfig | 1 +
> arch/riscv/include/asm/Kbuild | 1 +
> arch/riscv/include/asm/fixmap.h | 18 ++++++++++++++++++
> arch/riscv/include/asm/io.h | 1 +
> 4 files changed, 21 insertions(+)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index a197258595ef..f39e326a7a42 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -68,6 +68,7 @@ config RISCV
> select ARCH_HAS_GCOV_PROFILE_ALL
> select HAVE_COPY_THREAD_TLS
> select HAVE_ARCH_KASAN if MMU && 64BIT
> + select GENERIC_EARLY_IOREMAP
>
> config ARCH_MMAP_RND_BITS_MIN
> default 18 if 64BIT
> diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> index 3d9410bb4de0..59dd7be55005 100644
> --- a/arch/riscv/include/asm/Kbuild
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -1,4 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0
> +generic-y += early_ioremap.h
> generic-y += extable.h
> generic-y += flat.h
> generic-y += kvm_para.h
> diff --git a/arch/riscv/include/asm/fixmap.h b/arch/riscv/include/asm/fixmap.h
> index 2368d49eb4ef..ba5096d65fb0 100644
> --- a/arch/riscv/include/asm/fixmap.h
> +++ b/arch/riscv/include/asm/fixmap.h
> @@ -30,6 +30,24 @@ enum fixed_addresses {
> FIX_TEXT_POKE1,
> FIX_TEXT_POKE0,
> FIX_EARLYCON_MEM_BASE,
> + /*
> + * Make sure that it is 2MB aligned.
> + */
> +#define NR_FIX_SZ_2M (SZ_2M / PAGE_SIZE)
> + FIX_THOLE = NR_FIX_SZ_2M - FIX_PMD - 1,
> +
> + __end_of_permanent_fixed_addresses,
> + /*
> + * Temporary boot-time mappings, used by early_ioremap(),
> + * before ioremap() is functional.
> + */
> +#define NR_FIX_BTMAPS (SZ_256K / PAGE_SIZE)
> +#define FIX_BTMAPS_SLOTS 7
> +#define TOTAL_FIX_BTMAPS (NR_FIX_BTMAPS * FIX_BTMAPS_SLOTS)
> +
> + FIX_BTMAP_END = __end_of_permanent_fixed_addresses,
> + FIX_BTMAP_BEGIN = FIX_BTMAP_END + TOTAL_FIX_BTMAPS - 1,
> +
> __end_of_fixed_addresses
> };
>
> diff --git a/arch/riscv/include/asm/io.h b/arch/riscv/include/asm/io.h
> index 0f477206a4ed..047f414b6948 100644
> --- a/arch/riscv/include/asm/io.h
> +++ b/arch/riscv/include/asm/io.h
> @@ -14,6 +14,7 @@
> #include <linux/types.h>
> #include <asm/mmiowb.h>
> #include <asm/pgtable.h>
> +#include <asm/early_ioremap.h>
>
> /*
> * MMIO access functions are separated out to break dependency cycles
Just so it doesn't get lost (the patch is the same)
Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
next prev parent reply other threads:[~2020-04-21 19:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 3:33 [v4 PATCH 0/3] Add UEFI support for RISC-V Atish Patra
2020-04-21 3:33 ` [v4 PATCH 1/3] RISC-V: Define fixmap bindings for generic early ioremap support Atish Patra
2020-04-21 19:52 ` Palmer Dabbelt [this message]
2020-04-21 19:56 ` Atish Patra
2020-04-21 3:33 ` [v4 PATCH 2/3] RISC-V: Add PE/COFF header for EFI stub Atish Patra
2020-04-21 17:51 ` Ard Biesheuvel
2020-04-22 17:44 ` Atish Patra
2020-04-21 20:02 ` Palmer Dabbelt
2020-04-22 17:43 ` Atish Patra
2020-04-21 3:33 ` [v4 PATCH 3/3] RISC-V: Add EFI stub support Atish Patra
2020-04-21 20:08 ` Palmer Dabbelt
2020-04-22 17:45 ` Atish Patra
2020-04-21 7:24 ` [v4 PATCH 0/3] Add UEFI support for RISC-V Ard Biesheuvel
2020-04-21 17:29 ` Atish Patra
2020-04-21 20:59 ` Palmer Dabbelt
2020-04-22 16:39 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-613ec31b-83df-4a01-998c-e2d682787c1b@palmerdabbelt-glaptop1 \
--to=palmer@dabbelt.com \
--cc=Atish.Patra@wdc.com \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=masahiroy@kernel.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).