From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48A46C4360D for ; Wed, 25 Sep 2019 21:06:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2798721D7A for ; Wed, 25 Sep 2019 21:06:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393600AbfIYVGN (ORCPT ); Wed, 25 Sep 2019 17:06:13 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:35868 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393576AbfIYVFX (ORCPT ); Wed, 25 Sep 2019 17:05:23 -0400 Received: by mail-pl1-f194.google.com with SMTP id f19so170984plr.3 for ; Wed, 25 Sep 2019 14:05:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=gUT7L2UjxufsVBOfcfjfvQD60hO6N2xeQ8FpCxr2BGs=; b=lkvkK0eXSS0wUFMxVd1nEbRN60Km8P2uLg31anz8EGZOQiScuqdVSbRtbmWhz0bSKq o9NutbzfaatWRmcMY7/Jd/Ri0q1BSyjq3V56oavrMmm0rJUqv70M9UC8DYJsnUFkkJkQ S3tJfqeu4pdEbEjCBqa0kI62SqMDFTbxu9tM6KdI5/e5GaAJLzUHxgbdK859yqoHCnic J9817IQ7aaq/FSrCfKYeWfy7OCypfPB3lf39Kaul6IVANXn2Pwn2rHAvycXgRvtUUm8o Vli/CFZihYhgT/DYy4vgqJi6XPwc1IvmLj+HjaqRRhJqxqSSExt42m9eGCk98p9Do2Iq ZIpQ== X-Gm-Message-State: APjAAAWHozh7cazbz7Glc8fq1HPO2ujrYcwA2bTIfh8cG/oevTn5mlbU rhS6JMu9D1ud2OfZwLSpugHdgA== X-Google-Smtp-Source: APXvYqy3cdkMgg0isteeXigHPCd6gHDI1dxPmb1QD+beG2Jb9fWSTndwNiR0j1qEnTRyndocyS3IVQ== X-Received: by 2002:a17:902:7085:: with SMTP id z5mr56136plk.57.1569445520447; Wed, 25 Sep 2019 14:05:20 -0700 (PDT) Received: from localhost ([12.206.222.5]) by smtp.gmail.com with ESMTPSA id l189sm486896pgd.46.2019.09.25.14.05.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2019 14:05:19 -0700 (PDT) Date: Wed, 25 Sep 2019 14:05:19 -0700 (PDT) X-Google-Original-Date: Wed, 25 Sep 2019 13:56:27 PDT (-0700) Subject: Re: [PATCH 04/32] riscv: Use pr_warn instead of pr_warning In-Reply-To: <20190920062544.180997-5-wangkefeng.wang@huawei.com> CC: joe@perches.com, akpm@linux-foundation.org, mingo@redhat.com, davem@davemloft.net, acme@redhat.com, apw@canonical.com, peterz@infradead.org, ast@kernel.org, daniel@iogearbox.net, Greg KH , sergey.senozhatsky@gmail.com, pmladek@suse.com, Arnd Bergmann , linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com, Paul Walmsley , aou@eecs.berkeley.edu From: Palmer Dabbelt To: wangkefeng.wang@huawei.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Sep 2019 23:25:16 PDT (-0700), wangkefeng.wang@huawei.com wrote: > As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of > pr_warning"), removing pr_warning so all logging messages use a > consistent _warn style. Let's do it. > > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Signed-off-by: Kefeng Wang > --- > arch/riscv/kernel/module.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c > index 70bb94ae61c5..b7401858d872 100644 > --- a/arch/riscv/kernel/module.c > +++ b/arch/riscv/kernel/module.c > @@ -315,8 +315,8 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab, > /* Ignore unresolved weak symbol */ > if (ELF_ST_BIND(sym->st_info) == STB_WEAK) > continue; > - pr_warning("%s: Unknown symbol %s\n", > - me->name, strtab + sym->st_name); > + pr_warn("%s: Unknown symbol %s\n", > + me->name, strtab + sym->st_name); > return -ENOENT; > } Acked-by: Palmer Dabbelt I'm assuming this is going in through some other tree, LMK if that's not the case.