linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmerdabbelt@google.com>
To: lkp@intel.com
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH linus] RISC-V: gp_in_global can be static
Date: Thu, 21 May 2020 13:51:41 -0700 (PDT)	[thread overview]
Message-ID: <mhng-7dafbf2e-2bf8-447f-bb31-c3c640d0e898@palmerdabbelt-glaptop1> (raw)
In-Reply-To: <20200518050227.GA13086@f1dbffaf4744>

On Sun, 17 May 2020 22:02:27 PDT (-0700), lkp@intel.com wrote:
>
> Fixes: 52e7c52d2ded ("RISC-V: Stop relying on GCC's register allocator's hueristics")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>  process.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c
> index 610c11e916068..3b2933839d492 100644
> --- a/arch/riscv/kernel/process.c
> +++ b/arch/riscv/kernel/process.c
> @@ -22,7 +22,7 @@
>  #include <asm/switch_to.h>
>  #include <asm/thread_info.h>
>
> -unsigned long gp_in_global __asm__("gp");
> +static unsigned long gp_in_global __asm__("gp");
>
>  extern asmlinkage void ret_from_fork(void);
>  extern asmlinkage void ret_from_kernel_thread(void);

Thanks.  Looks like this is actually a real bug: gp_in_global was supposed to
have the "register" keyword, and missing that appears to cause the __asm__ to
be ignored.

      reply	other threads:[~2020-05-21 20:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <202005181328.2fITyRLh%lkp@intel.com>
2020-05-18  5:02 ` [RFC PATCH linus] RISC-V: gp_in_global can be static kbuild test robot
2020-05-21 20:51   ` Palmer Dabbelt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-7dafbf2e-2bf8-447f-bb31-c3c640d0e898@palmerdabbelt-glaptop1 \
    --to=palmerdabbelt@google.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).