From: Palmer Dabbelt <palmer@dabbelt.com>
To: drew@beagleboard.org
Cc: robh+dt@kernel.org, Paul Walmsley <paul.walmsley@sifive.com>,
michael.zhu@starfivetech.com, geert@linux-m68k.org,
tekkamanninja@gmail.com, kernel@esmil.dk,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, drew@beagleboard.org
Subject: Re: [PATCH v2] dt-bindings: riscv: add starfive jh7100 bindings
Date: Tue, 06 Jul 2021 16:16:56 -0700 (PDT) [thread overview]
Message-ID: <mhng-7fbbd583-fe4e-4f11-a028-3df3eca4ab41@palmerdabbelt-glaptop> (raw)
In-Reply-To: <20210625071240.577796-1-drew@beagleboard.org>
On Fri, 25 Jun 2021 00:12:42 PDT (-0700), drew@beagleboard.org wrote:
> Add DT binding documentation for the StarFive JH7100 Soc [1] and the
> BeagleV Starlight JH7100 board [2].
>
> [1] https://github.com/starfive-tech/beaglev_doc
> [2] https://github.com/beagleboard/beaglev-starlight
>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> v2 changes:
> - removed "items:" entry that only had "const: starfive,jh7100"
> - correct typo in Description:
>
> Results of running checks:
>
> $ make -j8 ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- dt_binding_check \
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/riscv/starfive.yaml
> DTEX Documentation/devicetree/bindings/riscv/starfive.example.dts
> DTC Documentation/devicetree/bindings/riscv/starfive.example.dt.yaml
> CHECK Documentation/devicetree/bindings/riscv/starfive.example.dt.yaml
>
> $ make -j8 ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- dtbs_check \
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/riscv/starfive.yaml
> DTC arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dt.yaml
> CHECK arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dt.yaml
>
> The dts file is from vendor repo and is being cleaned up right now in
> preperation for submitting to the mailing list:
> https://github.com/starfive-tech/linux/tree/beaglev/arch/riscv/boot/dts/starfive
>
> .../devicetree/bindings/riscv/starfive.yaml | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/riscv/starfive.yaml
>
> diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml
> new file mode 100644
> index 000000000000..68954d0a7108
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/riscv/starfive.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive SoC-based boards
> +
> +maintainers:
> + - Michael Zhu <michael.zhu@starfivetech.com>
> + - Drew Fustini <drew@beagleboard.org>
> +
> +description:
> + StarFive SoC-based boards
> +
> +properties:
> + $nodename:
> + const: '/'
> + compatible:
> + oneOf:
> + - items:
> + - const: beagle,beaglev-starlight-jh7100
> + - const: starfive,jh7100
The SiFive boards have
oneOf:
- items:
- enum:
- sifive,hifive-unleashed-a00
- const: sifive,fu540-c000
- const: sifive,fu540
IIUC there's no practical difference between a single-option enum and
the const, but it does bring up the board version number. Is there any
revision number on the beaglev boards?
> +
> +additionalProperties: true
> +
> +...
Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
as I'm assuming this is targeted towards the DT tree. Thanks!
prev parent reply other threads:[~2021-07-06 23:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 7:12 [PATCH v2] dt-bindings: riscv: add starfive jh7100 bindings Drew Fustini
2021-07-06 23:16 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-7fbbd583-fe4e-4f11-a028-3df3eca4ab41@palmerdabbelt-glaptop \
--to=palmer@dabbelt.com \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=geert@linux-m68k.org \
--cc=kernel@esmil.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=michael.zhu@starfivetech.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=tekkamanninja@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).