From: Palmer Dabbelt <email@example.com> To: firstname.lastname@example.org Cc: Christoph Hellwig <email@example.com>, firstname.lastname@example.org, Arnd Bergmann <email@example.com>, firstname.lastname@example.org, Andrew Waterman <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH v2 2/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h Date: Thu, 09 Aug 2018 18:03:54 -0700 (PDT) Message-ID: <mhng-80aa1c8e-e2ed-4662-8715-4bb9e6ba7598@palmer-si-x1c4> (raw) In-Reply-To: <20180809212422.GB13675@roeck-us.net> On Thu, 09 Aug 2018 14:24:22 PDT (-0700), email@example.com wrote: > On Thu, Aug 09, 2018 at 01:25:24PM -0700, Palmer Dabbelt wrote: >> This file is expected to be included multiple times in the same file in >> order to allow the __SYSCALL macro to generate system call tables. With >> a global include guard we end up missing __NR_riscv_flush_icache in the >> syscall table, which results in icache flushes that escape the vDSO call >> to not actually do anything. >> >> The fix is to move to per-#define include guards, which allows the >> system call tables to actually be populated. Thanks to Macrus Comstedt >> for finding and fixing the bug! >> >> I also went ahead and fixed the SPDX header to use a //-style comment, >> which I've been told is the canonical way to do it. >> >> Cc: Marcus Comstedt <firstname.lastname@example.org> >> Signed-off-by: Palmer Dabbelt <email@example.com> > > [Compile-]Tested-by: Guenter Roeck <firstname.lastname@example.org> > > on top of linux-next after reverting the version of the patch there. > > I also tried to run the resulting image (defconfig) with qemu (built > from https://github.com/riscv/riscv-qemu.git), but that still doesn't > work. I assume there are still some patches missing ? Do you have the PLIC patches? They'll be necessary to make this all work, and there's a v4 out now that when combined with for-next should get you to userspace. https://email@example.com/T/#u Also, what is your methodology? I follow https://wiki.qemu.org/Documentation/Platforms/RISCV and could could natively compile and run hello world with an earlier version of Christoph's patch set, which is really only cosmetically different than the v4. I use qemu's master branch as well, which when I tried was exactly 3.0.0-rc3.
next prev parent reply index Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-09 20:25 [PATCH v2 0/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls Palmer Dabbelt 2018-08-09 20:25 ` [PATCH v2 1/2] RISC-V: Define sys_riscv_flush_icache when SMP=n Palmer Dabbelt 2018-08-09 21:20 ` Guenter Roeck 2018-08-09 20:25 ` [PATCH v2 2/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h Palmer Dabbelt 2018-08-09 21:24 ` Guenter Roeck 2018-08-10 1:03 ` Palmer Dabbelt [this message] 2018-08-10 2:40 ` Guenter Roeck 2018-08-10 3:59 ` Palmer Dabbelt 2018-08-10 4:11 ` Guenter Roeck 2018-08-10 4:53 ` Guenter Roeck
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=mhng-80aa1c8e-e2ed-4662-8715-4bb9e6ba7598@palmer-si-x1c4 \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ firstname.lastname@example.org email@example.com public-inbox-index lkml Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/ public-inbox