linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] riscv: dts: unleashed: Add gpio card detect to mmc-spi-slot
@ 2021-06-16  7:46 Bin Meng
  2021-06-16  7:46 ` [PATCH 2/2] riscv: dts: unmatched: " Bin Meng
  2021-07-08 13:40 ` [PATCH 1/2] riscv: dts: unleashed: " Bin Meng
  0 siblings, 2 replies; 4+ messages in thread
From: Bin Meng @ 2021-06-16  7:46 UTC (permalink / raw)
  To: Palmer Dabbelt, Paul Walmsley, David Abdurachmanov, linux-kernel,
	linux-riscv
  Cc: Bin Meng

From: Bin Meng <bin.meng@windriver.com>

Per HiFive Unleashed schematics, the card detect signal of the
micro SD card is connected to gpio pin #11, which should be
reflected in the DT via the <gpios> property, as described in
Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt.

[1] https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

 arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
index 60846e88ae4b..22f971e97161 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
@@ -80,6 +80,7 @@ mmc@0 {
 		spi-max-frequency = <20000000>;
 		voltage-ranges = <3300 3300>;
 		disable-wp;
+		gpios = <&gpio 11 GPIO_ACTIVE_LOW>;
 	};
 };
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 2/2] riscv: dts: unmatched: Add gpio card detect to mmc-spi-slot
  2021-06-16  7:46 [PATCH 1/2] riscv: dts: unleashed: Add gpio card detect to mmc-spi-slot Bin Meng
@ 2021-06-16  7:46 ` Bin Meng
  2021-07-08 13:40 ` [PATCH 1/2] riscv: dts: unleashed: " Bin Meng
  1 sibling, 0 replies; 4+ messages in thread
From: Bin Meng @ 2021-06-16  7:46 UTC (permalink / raw)
  To: Palmer Dabbelt, Paul Walmsley, David Abdurachmanov, linux-kernel,
	linux-riscv
  Cc: Bin Meng

From: Bin Meng <bin.meng@windriver.com>

Per HiFive Unmatched schematics, the card detect signal of the
micro SD card is connected to gpio pin #15, which should be
reflected in the DT via the <gpios> property, as described in
Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt.

[1] https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4192_hifive-unmatched-schematics-v3.pdf

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

 arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index b1c3c596578f..214794363c6a 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -2,6 +2,7 @@
 /* Copyright (c) 2020 SiFive, Inc */
 
 #include "fu740-c000.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 
 /* Clock frequency (in Hz) of the PCB crystal for rtcclk */
@@ -228,6 +229,7 @@ mmc@0 {
 		spi-max-frequency = <20000000>;
 		voltage-ranges = <3300 3300>;
 		disable-wp;
+		gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
 	};
 };
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] riscv: dts: unleashed: Add gpio card detect to mmc-spi-slot
  2021-06-16  7:46 [PATCH 1/2] riscv: dts: unleashed: Add gpio card detect to mmc-spi-slot Bin Meng
  2021-06-16  7:46 ` [PATCH 2/2] riscv: dts: unmatched: " Bin Meng
@ 2021-07-08 13:40 ` Bin Meng
  2021-11-24 16:58   ` Palmer Dabbelt
  1 sibling, 1 reply; 4+ messages in thread
From: Bin Meng @ 2021-07-08 13:40 UTC (permalink / raw)
  To: Palmer Dabbelt, Paul Walmsley, David Abdurachmanov, linux-kernel,
	linux-riscv
  Cc: Bin Meng

On Wed, Jun 16, 2021 at 3:46 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> Per HiFive Unleashed schematics, the card detect signal of the
> micro SD card is connected to gpio pin #11, which should be
> reflected in the DT via the <gpios> property, as described in
> Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt.
>
> [1] https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
>  arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 +
>  1 file changed, 1 insertion(+)
>

Ping?

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] riscv: dts: unleashed: Add gpio card detect to mmc-spi-slot
  2021-07-08 13:40 ` [PATCH 1/2] riscv: dts: unleashed: " Bin Meng
@ 2021-11-24 16:58   ` Palmer Dabbelt
  0 siblings, 0 replies; 4+ messages in thread
From: Palmer Dabbelt @ 2021-11-24 16:58 UTC (permalink / raw)
  To: bmeng.cn
  Cc: Paul Walmsley, david.abdurachmanov, linux-kernel, linux-riscv, bin.meng

On Thu, 08 Jul 2021 06:40:03 PDT (-0700), bmeng.cn@gmail.com wrote:
> On Wed, Jun 16, 2021 at 3:46 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>>
>> From: Bin Meng <bin.meng@windriver.com>
>>
>> Per HiFive Unleashed schematics, the card detect signal of the
>> micro SD card is connected to gpio pin #11, which should be
>> reflected in the DT via the <gpios> property, as described in
>> Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt.
>>
>> [1] https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf
>>
>> Signed-off-by: Bin Meng <bin.meng@windriver.com>
>> ---
>>
>>  arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 +
>>  1 file changed, 1 insertion(+)
>>
>
> Ping?

Sorry I missed these, and thanks to David for pointing them out.  
They're on fixes.

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-24 16:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16  7:46 [PATCH 1/2] riscv: dts: unleashed: Add gpio card detect to mmc-spi-slot Bin Meng
2021-06-16  7:46 ` [PATCH 2/2] riscv: dts: unmatched: " Bin Meng
2021-07-08 13:40 ` [PATCH 1/2] riscv: dts: unleashed: " Bin Meng
2021-11-24 16:58   ` Palmer Dabbelt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).