From: Palmer Dabbelt <palmer@dabbelt.com>
To: alex@ghiti.fr
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
dvyukov@google.com, linux-api@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
alex@ghiti.fr
Subject: Re: [PATCH] riscv: Bump COMMAND_LINE_SIZE value to 1024
Date: Mon, 29 Mar 2021 22:07:47 -0700 (PDT) [thread overview]
Message-ID: <mhng-885e3a79-49cf-42fc-8561-a52c7b7e1ac6@palmerdabbelt-glaptop> (raw)
In-Reply-To: <20210316193420.904-1-alex@ghiti.fr>
On Tue, 16 Mar 2021 12:34:20 PDT (-0700), alex@ghiti.fr wrote:
> Increase COMMAND_LINE_SIZE as the current default value is too low
> for syzbot kernel command line.
>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Alexandre Ghiti <alex@ghiti.fr>
> ---
> arch/riscv/include/uapi/asm/setup.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
> create mode 100644 arch/riscv/include/uapi/asm/setup.h
>
> diff --git a/arch/riscv/include/uapi/asm/setup.h b/arch/riscv/include/uapi/asm/setup.h
> new file mode 100644
> index 000000000000..66b13a522880
> --- /dev/null
> +++ b/arch/riscv/include/uapi/asm/setup.h
> @@ -0,0 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */
> +
> +#ifndef _UAPI_ASM_RISCV_SETUP_H
> +#define _UAPI_ASM_RISCV_SETUP_H
> +
> +#define COMMAND_LINE_SIZE 1024
> +
> +#endif /* _UAPI_ASM_RISCV_SETUP_H */
I put this on fixes, but it seemes like this should really be a Kconfig
enttry. Either way, ours was quite a bit smaller than most
architectures and it's great that syzbot has started to find bugs, so
I'd rather get this in sooner.
next prev parent reply other threads:[~2021-03-30 5:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 19:34 [PATCH] riscv: Bump COMMAND_LINE_SIZE value to 1024 Alexandre Ghiti
2021-03-30 5:07 ` Palmer Dabbelt [this message]
2021-03-30 20:31 ` Maciej W. Rozycki
2021-04-02 4:37 ` Palmer Dabbelt
2021-04-02 8:40 ` Dmitry Vyukov
2021-04-02 8:58 ` David Abdurachmanov
2021-04-02 18:33 ` Maciej W. Rozycki
2021-04-23 2:57 ` Palmer Dabbelt
2021-06-21 7:11 ` Alex Ghiti
2022-11-10 21:01 ` Dmitry Vyukov
2023-02-09 11:37 ` Dmitry Vyukov
2023-02-09 19:30 ` Alex Ghiti
2023-03-02 3:17 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-885e3a79-49cf-42fc-8561-a52c7b7e1ac6@palmerdabbelt-glaptop \
--to=palmer@dabbelt.com \
--cc=alex@ghiti.fr \
--cc=dvyukov@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).