From: Palmer Dabbelt <palmer@rivosinc.com>
To: ogabbay@kernel.org
Cc: Greg KH <gregkh@linuxfoundation.org>,
linux-riscv@lists.infradead.org, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, osharabi@habana.ai
Subject: Re: [PATCH] habanalabs: Elide a warning on 32-bit targets
Date: Fri, 01 Apr 2022 11:36:53 -0700 (PDT) [thread overview]
Message-ID: <mhng-89bfa679-14d3-436e-80e1-439ab154beb2@palmer-mbp2014> (raw)
In-Reply-To: <CAFCwf13-o=kUR61xjWt=F-Q-Vfy=kF6fpMP7iB+83Gfqw7+2HA@mail.gmail.com>
On Fri, 01 Apr 2022 11:13:48 PDT (-0700), ogabbay@kernel.org wrote:
> On Fri, Apr 1, 2022 at 7:41 PM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>>
>> From: Palmer Dabbelt <palmer@rivosinc.com>
>>
>> This double-cast pattern looks a bit awkward, but it already exists
>> elsewhere in the driver. Without this patch I get
>>
>> drivers/misc/habanalabs/common/memory.c: In function ‘alloc_device_memory’:
>> drivers/misc/habanalabs/common/memory.c:153:49: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>> 153 | (u64) gen_pool_dma_alloc_align(vm->dram_pg_pool,
>> | ^
>>
>> which ends up promoted to a build error in my test setup.
>>
>> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
>>
>> ---
>>
>> I don't know anything about this driver, I'm just pattern-matching the
>> warning away.
>> ---
>> drivers/misc/habanalabs/common/memory.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/misc/habanalabs/common/memory.c b/drivers/misc/habanalabs/common/memory.c
>> index e008d82e4ba3..f1fc79c1fc10 100644
>> --- a/drivers/misc/habanalabs/common/memory.c
>> +++ b/drivers/misc/habanalabs/common/memory.c
>> @@ -150,12 +150,12 @@ static int alloc_device_memory(struct hl_ctx *ctx, struct hl_mem_in *args,
>> for (i = 0 ; i < num_pgs ; i++) {
>> if (is_power_of_2(page_size))
>> phys_pg_pack->pages[i] =
>> - (u64) gen_pool_dma_alloc_align(vm->dram_pg_pool,
>> - page_size, NULL,
>> - page_size);
>> + (u64) (uintptr_t) gen_pool_dma_alloc_align(vm->dram_pg_pool,
>> + page_size, NULL,
>> + page_size);
>> else
>> - phys_pg_pack->pages[i] = (u64) gen_pool_alloc(vm->dram_pg_pool,
>> - page_size);
>> + phys_pg_pack->pages[i] = (u64) (uintptr_t) gen_pool_alloc(vm->dram_pg_pool,
>> + page_size);
>> if (!phys_pg_pack->pages[i]) {
>> dev_err(hdev->dev,
>> "Failed to allocate device memory (out of memory)\n");
>> --
>> 2.34.1
>>
>
> This patch is:
> Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
>
> Greg,
> Could you please apply this directly to your misc tree and send it to
> Linus at your next pull request ?
> I don't have any other fixes pending for 5.18.
>
> For 5.19 we will do a more elegant solution that Arnd has recommended.
Thanks.
Assuming this is too late for rc1, would it be possibe to have it in
something I can take into my fixes/for-next without too much diff? I
put this on top of the offending commit with a
Fixes: e8458e20e0a3 ("habanalabs: make sure device mem alloc is page aligned")
at kernel.org/palmer/habana , if that helps any. No big deal if it goes
in another way, it's just nice to keep allyesconfig building on my
branches directly.
next prev parent reply other threads:[~2022-04-01 18:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 16:39 [PATCH] habanalabs: Elide a warning on 32-bit targets Palmer Dabbelt
2022-04-01 18:13 ` Oded Gabbay
2022-04-01 18:36 ` Palmer Dabbelt [this message]
2022-04-04 15:02 ` Greg KH
2022-04-05 0:43 ` Palmer Dabbelt
2022-04-05 5:03 ` Greg KH
2022-04-02 7:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-89bfa679-14d3-436e-80e1-439ab154beb2@palmer-mbp2014 \
--to=palmer@rivosinc.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=ogabbay@kernel.org \
--cc=osharabi@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).