linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@sifive.com>
To: tglx@linutronix.de
Cc: Arnd Bergmann <arnd@arndb.de>,
	fengguang.wu@intel.com, kbuild-all@01.org,
	linux-kernel@vger.kernel.org, tipbuild@zytor.com
Subject: Re: [tip:irq/core 12/13] drivers/irqchip/irq-vic.c:295:2: error: implicit declaration of function 'set_handle_irq'; did you mean 'vic_handle_irq'?
Date: Tue, 27 Mar 2018 09:18:47 -0700 (PDT)	[thread overview]
Message-ID: <mhng-b8f6e13a-d514-4af3-936e-22dd9ab9a546@palmer-si-x1c4> (raw)
In-Reply-To: <alpine.DEB.2.21.1803271734170.1964@nanos.tec.linutronix.de>

On Tue, 27 Mar 2018 08:38:29 PDT (-0700), tglx@linutronix.de wrote:
> On Tue, 27 Mar 2018, Palmer Dabbelt wrote:
>> On Mon, 26 Mar 2018 22:27:36 PDT (-0700), tglx@linutronix.de wrote:
>> >
>> > The commits in tip right now are:
>> >
>> >   cc6c98485f8e ("RISC-V: Move to the new GENERIC_IRQ_MULTI_HANDLER handler")
>> >   caacdbf4aa56 ("genirq: Add CONFIG_GENERIC_IRQ_MULTI_HANDLER")
>> >
>> > I surely can revert them, but I don't see how they would break arm or
>> > anything else.
>>
>> If GENERIC_IRQ_MULTI_HANDLER is set via randconfig then set_handle_irq() is
>> pulled in from the generic code, which conflicts with the definitions in arm,
>> arm64, and openrisc.  The RISC-V commit depends on the genirq one.
>
> Two ways to fix that:
>
>  - Rename set_handle_irq() in tip:irq/core and then convert the rest of the
>    tree over. A few more files touched, but nothing harmful
>
>  - Make GENERIC_IRQ_MULTI_HANDLER depend on !IRQ_MULTI_HANDLER. That should
>    cure it as well

I have a patch set that does the second one, but it's done in a manner that 
assumes the partial patch set got merged.  Let me just send it out...

      reply	other threads:[~2018-03-27 16:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19 21:53 [tip:irq/core 12/13] drivers/irqchip/irq-vic.c:295:2: error: implicit declaration of function 'set_handle_irq'; did you mean 'vic_handle_irq'? kbuild test robot
2018-03-20  7:53 ` Thomas Gleixner
2018-03-20 17:52   ` Palmer Dabbelt
2018-03-26  8:07     ` Arnd Bergmann
2018-03-26 18:08       ` Palmer Dabbelt
2018-03-27  5:27         ` Thomas Gleixner
2018-03-27 15:31           ` Palmer Dabbelt
2018-03-27 15:38             ` Thomas Gleixner
2018-03-27 16:18               ` Palmer Dabbelt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-b8f6e13a-d514-4af3-936e-22dd9ab9a546@palmer-si-x1c4 \
    --to=palmer@sifive.com \
    --cc=arnd@arndb.de \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tipbuild@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).