From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751598AbdK3TJ1 (ORCPT ); Thu, 30 Nov 2017 14:09:27 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:42626 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbdK3TJ0 (ORCPT ); Thu, 30 Nov 2017 14:09:26 -0500 X-Google-Smtp-Source: AGs4zMbFKcvFfdvFdnfgxNlCPG+alOO5NPsrhX37sG71etxqhYf/+PphbhdEuTTprVmtlB0o+dDhXQ== Date: Thu, 30 Nov 2017 11:09:24 -0800 (PST) X-Google-Original-Date: Thu, 30 Nov 2017 11:09:17 PST (-0800) Subject: Re: [patches] Re: [PATCH] riscv/ftrace: Add basic support In-Reply-To: CC: nonerkao@gmail.com, albert@sifive.com, rostedt@goodmis.org, patches@groups.riscv.org, mingo@redhat.com, linux-kernel@vger.kernel.org, alankao@andestech.com From: Palmer Dabbelt To: pombredanne@nexb.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Nov 2017 03:31:53 PST (-0800), pombredanne@nexb.com wrote: > On Thu, Nov 30, 2017 at 9:53 AM, Alan Kao wrote: > [] >> diff --git a/arch/riscv/include/asm/ftrace.h b/arch/riscv/include/asm/ftrace.h >> new file mode 100644 >> index 000000000000..38beadb07ad5 >> --- /dev/null >> +++ b/arch/riscv/include/asm/ftrace.h >> @@ -0,0 +1,23 @@ >> +/* >> + * Copyright (C) 2017 Andes Technology Corporation >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program. If not, see . >> + */ > > You may want to use the new SPDX ids here instead? > e.g. >> +// SPDX-License-Identifer: GPL-2.0 >> +// Copyright (C) 2017 Andes Technology Corporation > > Neater and simpler? > See Linus posts on the topic of comment styles too BTW I believe we need to convert all the RISC-V stuff to SPDX headers, that change happened between when we got the port reviewed and made it into Linus' tree. Do you happen to know if there's some script I can run to do this automatically?