From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 952CCC433DF for ; Tue, 16 Jun 2020 18:07:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C8F62080D for ; Tue, 16 Jun 2020 18:07:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=dabbelt-com.20150623.gappssmtp.com header.i=@dabbelt-com.20150623.gappssmtp.com header.b="RCyQhgyI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731411AbgFPSHM (ORCPT ); Tue, 16 Jun 2020 14:07:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727083AbgFPSHK (ORCPT ); Tue, 16 Jun 2020 14:07:10 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AD05C061573 for ; Tue, 16 Jun 2020 11:07:09 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id m7so8729710plt.5 for ; Tue, 16 Jun 2020 11:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=bPVOaaVIj3IEJ35IEXDyaVgJGxpBPUItBjOGuVz6Vrg=; b=RCyQhgyIyuDy8/u9yIX9Wyq4Qh6u+F0/7cq6wi47MjSk4MIFA6zPjgvhwHEeiZtBWB VGLleJxPzbjrF1IkhrBLAY7+MU/ZK7FW4Lz/1VLPD35Q0KnPzrhRFi4GwBgp8EL1W+Fn 1c9CuFuWBTdroJFgm/XlRcv0FeksnncU5mw2TQqAyEbDXQnnkOksQr/QvqLkHud0HVzk D3ObcCXYgE6Dj5Bgq5MgxpngmHehzDPdyTVgxwHWmC0DXzEl6TayjdGI5KV1KZBLLVOU FhGj+Q8U1qbkbxFkTyJq1fiBNZHWcbWH4n1CCL8ENCeQCN5rIk0C5c2EYSH/KWbrHy4q R27w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=bPVOaaVIj3IEJ35IEXDyaVgJGxpBPUItBjOGuVz6Vrg=; b=NRvfRZxMIbDPcY9CXoZXNU10uXZN6NRh3mAS+ckNv4L9f3saDB3Zyd69xIyP6Yn5jD YSbWxjfWCbhLbjXpCvsqOzU5xI6gEUumQW3Is/5Ny0Zr12AAV+c4AyVliZubTNL87sYz 0AlnCJLWyhs/vKI9Nw+yTMpBkNcVGnj+UZbM/CFvvNOYxeO3HFxteBg7JYvdwum674ez aEoHW/lqBNqnOdh+0z8ajP5JJIfnTokVEZw352zfkgK35h2p6yWr+9e7cpDO5tC2ke+p BuI2md//swyhCjMNZgSmQsqHfxmU4dfWvM8Tp48AnHtVa9O5yrf6ijeD78b3bArfQrW0 UkTQ== X-Gm-Message-State: AOAM532/29nZvsOrfbZ5GqPKuGR/RLZyOsnsxNTzGPUSd/10QCUcokaK XpGzuSMPuyqrSBhWA8lhrgucnw== X-Google-Smtp-Source: ABdhPJxKWpmsQ4Gg2Nz1OYscOq9l1dmUhVjXayq4pQwo4tqjqrLCHDaOSKw46e2dwdSRJnxM/FWuqQ== X-Received: by 2002:a17:90a:7347:: with SMTP id j7mr4071769pjs.128.1592330828506; Tue, 16 Jun 2020 11:07:08 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id m9sm14170786pgq.61.2020.06.16.11.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 11:07:07 -0700 (PDT) Date: Tue, 16 Jun 2020 11:07:07 -0700 (PDT) X-Google-Original-Date: Tue, 16 Jun 2020 11:07:06 PDT (-0700) Subject: Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V In-Reply-To: CC: walken@google.com, shorne@gmail.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Topel From: Palmer Dabbelt To: atishp@atishpatra.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Jun 2020 10:54:51 PDT (-0700), atishp@atishpatra.org wrote: > On Tue, Jun 16, 2020 at 3:45 AM Michel Lespinasse wrote: >> >> I am also unable to reproduce the issue so far. >> >> I wanted to point to a few things in case this helps: >> - Commit 42fc541404f2 was bisected as the cause. This commit changes >> walk_page_range_novma() to use mmap_assert_locked() instead of >> lockdep_assert_held() >> - mmap_assert_locked() checks lockdep_assert_held(), but also checks >> that the rwsem itself is locked. >> >> Now how could lockdep think the lock is held, but the lock itself is >> not marked as locked ??? >> >> I'm not sure if it helps at all, but a few commits earlier, >> 0cc55a0213a0 introduces mmap_read_trylock_non_owner(), which is used >> exclusively by stackmap, and does the opposite: it acquires the mmap >> lock without telling lockdep about it. I can't see any smoking gun >> linking this to our bug, but I thought it may be worth mentioning as >> it involves the same suspects (stackmap and the difference between >> owning the lock vs lockdep thinking we own the lock). >> >> I'm sorry, that's only how far I was able to go on this bug - I'm not >> sure how to investigate it further as I can not reproduce the issue... >> >> On Tue, Jun 16, 2020 at 1:40 AM Palmer Dabbelt wrote: >> > >> > On Mon, 15 Jun 2020 21:51:08 PDT (-0700), shorne@gmail.com wrote: >> > > On Tue, Jun 16, 2020 at 06:57:47AM +0900, Stafford Horne wrote: >> > >> On Mon, Jun 15, 2020 at 12:28:11AM -0700, Atish Patra wrote: >> > >> > Hi, >> > >> > I encountered the following issue while booting 5.8-rc1 on Qemu for RV64. >> > >> > I added additional dump_stack and observed that it's happening in bpf free path. >> > >> > It happens always if CONFIG_DEBUG_VM is enabled. VM_BUG_ON_MM is >> > >> > compiled away without that. >> > >> > ------------------------------------------------------------------------ >> > >> > forked to background, child pid 113 >> > >> > [ 10.328850] CPU: 3 PID: 51 Comm: kworker/3:1 Not tainted >> > >> > 5.8.0-rc1-dirty #732 >> > >> > [ 10.331739] Workqueue: events bpf_prog_free_deferred >> > >> > [ 10.334133] Call Trace: >> > >> > [ 10.338039] [] walk_stackframe+0x0/0xa4 >> > >> > [ 10.339988] [] show_stack+0x2e/0x3a >> > >> > [ 10.340902] [] dump_stack+0x72/0x8c >> > >> > [ 10.341451] [] mmap_assert_locked.part.13+0x14/0x1c >> > >> > [ 10.342131] [] walk_page_range_novma+0x0/0x4e >> > >> > [ 10.342973] [] set_direct_map_invalid_noflush+0x66/0x6e >> > >> > [ 10.343917] [] __vunmap+0xe8/0x212 >> > >> > [ 10.344680] [] __vfree+0x22/0x6e >> > >> > [ 10.345270] [] vfree+0x34/0x56 >> > >> > [ 10.345834] [] __bpf_prog_free+0x2c/0x36 >> > >> > [ 10.346529] [] bpf_prog_free_deferred+0x74/0x8a >> > >> > [ 10.347394] [] process_one_work+0x13a/0x272 >> > >> > [ 10.348239] [] worker_thread+0x50/0x2e4 >> > >> > [ 10.348900] [] kthread+0xfc/0x10a >> > >> > [ 10.349470] [] ret_from_exception+0x0/0xc >> > >> > [ 10.354405] mm ffffffe001018600 mmap 0000000000000000 seqnum 0 task_size 0 >> > >> > [ 10.354405] get_unmapped_area 0000000000000000 >> > >> > [ 10.354405] mmap_base 0 mmap_legacy_base 0 highest_vm_end 0 >> > >> > [ 10.354405] pgd ffffffe001074000 mm_users 2 mm_count 1 >> > >> > pgtables_bytes 8192 map_count 0 >> > >> > [ 10.354405] hiwater_rss 0 hiwater_vm 0 total_vm 0 locked_vm 0 >> > >> > [ 10.354405] pinned_vm 0 data_vm 0 exec_vm 0 stack_vm 0 >> > >> > [ 10.354405] start_code ffffffe000200000 end_code ffffffe00084acc2 >> > >> > start_data 0 end_data ffffffe00106dfe4 >> > >> > [ 10.354405] start_brk 0 brk ffffffe0010bd6d0 start_stack 0 >> > >> > [ 10.354405] arg_start 0 arg_end 0 env_start 0 env_end 0 >> > >> > [ 10.354405] binfmt 0000000000000000 flags 0 core_state 0000000000000000 >> > >> > [ 10.354405] ioctx_table 0000000000000000 >> > >> > [ 10.354405] exe_file 0000000000000000 >> > >> > [ 10.354405] tlb_flush_pending 0 >> > >> > [ 10.354405] def_flags: 0x0() >> > >> > [ 10.369325] ------------[ cut here ]------------ >> > >> > [ 10.370763] kernel BUG at include/linux/mmap_lock.h:81! >> > >> > [ 10.375235] Kernel BUG [#1] >> > >> > [ 10.377198] Modules linked in: >> > >> > [ 10.378931] CPU: 3 PID: 51 Comm: kworker/3:1 Not tainted 5.8.0-rc1-dirty #732 >> > >> > [ 10.380179] Workqueue: events bpf_prog_free_deferred >> > >> > [ 10.381270] epc: ffffffe0002db4d4 ra : ffffffe0002db4d4 sp : ffffffe3eaea7c70 >> > >> > [ 10.382561] gp : ffffffe00106d950 tp : ffffffe3ef752f80 t0 : >> > >> > ffffffe0010836e8 >> > >> > [ 10.383996] t1 : 0000000000000064 t2 : 0000000000000000 s0 : >> > >> > ffffffe3eaea7c90 >> > >> > [ 10.385119] s1 : ffffffe001018600 a0 : 0000000000000289 a1 : >> > >> > 0000000000000020 >> > >> > [ 10.386099] a2 : 0000000000000005 a3 : 0000000000000000 a4 : >> > >> > ffffffe001012758 >> > >> > [ 10.387294] a5 : 0000000000000000 a6 : 0000000000000102 a7 : >> > >> > 0000000000000006 >> > >> > [ 10.388265] s2 : ffffffe3f00674c0 s3 : ffffffe00106e108 s4 : >> > >> > ffffffe00106e100 >> > >> > [ 10.389250] s5 : ffffffe00106e908 s6 : 0000000000000000 s7 : >> > >> > 6db6db6db6db6db7 >> > >> > [ 10.390272] s8 : 0000000000000001 s9 : ffffffe00021a4f8 s10: >> > >> > ffffffffffffffff >> > >> > [ 10.391293] s11: ffffffe3f0066600 t3 : 000000000001a7a8 t4 : >> > >> > 000000000001a7a8 >> > >> > [ 10.392314] t5 : 0000000000000000 t6 : ffffffe00107b76b >> > >> > [ 10.393096] status: 0000000000000120 badaddr: 0000000000000000 >> > >> > cause: 0000000000000003 >> > >> > [ 10.397755] ---[ end trace 861659596ac28841 ]--- >> > >> > --------------------------------------------------------------------------------------------------- >> > >> > >> > >> > I haven't had the chance to bisect to figure out which commit caused >> > >> > the issue. Just wanted >> > >> > to check if it is a known issue already. >> > >> >> > >> Hi Atish, >> > >> >> > >> Note, I am getting the same (just now) when booting v5.8-rc1 on OpenRISC. If >> > >> you have any updates please post back. I will try to look into this today or >> > >> tomorrow. >> > > >> > > I have bisected this to, 42fc541404f249778e752ab39c8bc25fcb2dbe1e: >> > > >> > > mmap locking API: add mmap_assert_locked() and mmap_assert_write_locked() >> > > >> > > This should have just changed the existing lockdep api's but something has >> > > changed. I haven't had time to look at it yet. >> > > >> > > Ccing: Michel Lespinasse >> > >> > This isn't manifesting on boot for me, on either rc1 or that commit. I'm >> > running a simple buildroot-based userspace, so I doubt anything is triggering >> > BPF. I don't run the BPF selftests, as they're a bit of a pain (IIRC they >> > don't cross compile and need LLVM) -- does anyone have a userspace I can use to >> > trigger the bug? >> > I am also using buildroot based userspace but it's a bit bulky because > of my config. > You can access it from here: > https://wdc.box.com/s/r8j0d5ynp5gr27n2wo124xi9t8fp0tls I'm up to ~900M trying to get enough of a userspace to run the BPF selftests, so this would be way better. Unfortunately I'm not actually getting the crash with your rootfs. > > A defconfig build & boot in Qemu with above userspace is sufficient to > trigger the bug. > > FYI: I noticed the kernel bug message every time during ssh-key > generation. Not sure if that is related. > >> >> >> -- >> Michel "Walken" Lespinasse >> A program is never fully debugged until the last user dies.