From: Palmer Dabbelt <palmer@dabbelt.com>
To: bmeng.cn@gmail.com
Cc: geert@linux-m68k.org, lewis.hanly@microchip.com,
Atish Patra <Atish.Patra@wdc.com>,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
bin.meng@windriver.com
Subject: Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node
Date: Tue, 03 Aug 2021 21:18:36 -0700 (PDT) [thread overview]
Message-ID: <mhng-e1c39f7c-9667-4711-b2fc-0875cd0695a9@palmerdabbelt-glaptop> (raw)
In-Reply-To: <CAEUhbmUkuKd7itzvQyzrYeqfUQv6LCqkXDsO=yufQppDBceLQQ@mail.gmail.com>
On Tue, 03 Aug 2021 20:55:56 PDT (-0700), bmeng.cn@gmail.com wrote:
> On Wed, Aug 4, 2021 at 11:55 AM Palmer Dabbelt <palmer@dabbelt.com> wrote:
>>
>> On Fri, 16 Jul 2021 04:34:02 PDT (-0700), geert@linux-m68k.org wrote:
>> > Hi Bin,
>> >
>> > On Fri, Jul 16, 2021 at 12:14 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>> >> On Fri, Jul 16, 2021 at 5:23 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> >> > On Fri, Jul 2, 2021 at 3:44 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>> >> > > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
>> >> > > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
>> >> > > @@ -9,6 +9,10 @@ / {
>> >> > > model = "Microchip MPFS Icicle Kit";
>> >> > > compatible = "microchip,mpfs-icicle-kit";
>> >> > >
>> >> > > + aliases {
>> >> > > + ethernet0 = &emac1;
>> >> > > + };
>> >> > > +
>> >> > > chosen {
>> >> > > };
>> >> >
>> >> > This should be added to the board DTS (microchip-mpfs-icicle-kit.dts)
>> >> > instead.
>> >>
>> >> I was wondering the same thing before doing this, but when I checked
>> >> all other DTS in arch/riscv/boot I found the aliases node is put in
>> >> the SoC dtsi file instead of the board on so I think that's the
>> >> convention.
>> >
>> > The numbering of the aliases is supposed to match the labels on the
>> > board, hence it is board-specific, not SoC-specific.
>> >
>> > Gr{oetje,eeting}s,
>> >
>> > Geert
>>
>> I don't see a v2 of this.
>
> Will send v2 soon.
Thanks. I'm assuming you're going to send both patches.
next prev parent reply other threads:[~2021-08-04 4:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 1:43 [PATCH 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1 Bin Meng
2021-07-02 1:43 ` [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node Bin Meng
2021-07-09 10:06 ` Conor.Dooley
2021-07-16 9:23 ` Geert Uytterhoeven
2021-07-16 10:14 ` Bin Meng
2021-07-16 11:34 ` Geert Uytterhoeven
2021-08-04 3:55 ` Palmer Dabbelt
2021-08-04 3:55 ` Bin Meng
2021-08-04 4:18 ` Palmer Dabbelt [this message]
2021-07-08 13:40 ` [PATCH 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1 Bin Meng
2021-07-09 9:20 ` Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-e1c39f7c-9667-4711-b2fc-0875cd0695a9@palmerdabbelt-glaptop \
--to=palmer@dabbelt.com \
--cc=Atish.Patra@wdc.com \
--cc=bin.meng@windriver.com \
--cc=bmeng.cn@gmail.com \
--cc=geert@linux-m68k.org \
--cc=lewis.hanly@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).