From: Palmer Dabbelt <palmer@sifive.com>
To: me@packi.ch
Cc: linux-riscv@lists.infradead.org, me@packi.ch,
aou@eecs.berkeley.edu, atish.patra@wdc.com, anup@brainfault.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] RISC-V: recognize S/U mode bits in print_isa
Date: Fri, 16 Nov 2018 08:52:16 -0800 (PST) [thread overview]
Message-ID: <mhng-e9ecd06a-7b9c-4b0f-af31-2c4c3b64c1a5@palmer-si-x1c4> (raw)
In-Reply-To: <20181109214217.27494-1-me@packi.ch>
On Fri, 09 Nov 2018 13:42:16 PST (-0800), me@packi.ch wrote:
> Removes the warning about an unsupported ISA when reading /proc/cpuinfo
> on QEMU. The "S" extension is not being returned as it is not accessible
> from userspace.
>
> Signed-off-by: Patrick Stählin <me@packi.ch>
> ---
> arch/riscv/kernel/cpu.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/arch/riscv/kernel/cpu.c b/arch/riscv/kernel/cpu.c
> index 3a5a2ee31547..b4a7d4427fbb 100644
> --- a/arch/riscv/kernel/cpu.c
> +++ b/arch/riscv/kernel/cpu.c
> @@ -64,7 +64,7 @@ int riscv_of_processor_hartid(struct device_node *node)
>
> static void print_isa(struct seq_file *f, const char *orig_isa)
> {
> - static const char *ext = "mafdc";
> + static const char *ext = "mafdcsu";
> const char *isa = orig_isa;
> const char *e;
>
> @@ -88,11 +88,14 @@ static void print_isa(struct seq_file *f, const char *orig_isa)
> /*
> * Check the rest of the ISA string for valid extensions, printing those
> * we find. RISC-V ISA strings define an order, so we only print the
> - * extension bits when they're in order.
> + * extension bits when they're in order. Hide the supervisor (S)
> + * extension from userspace as it's not accessible from there.
> */
> for (e = ext; *e != '\0'; ++e) {
> if (isa[0] == e[0]) {
> - seq_write(f, isa, 1);
> + if (isa[0] != 's')
> + seq_write(f, isa, 1);
> +
> isa++;
> }
> }
This looks good to me. I'll target it for the RCs, as it's fairly small and
that warning fires too often.
Thanks!
prev parent reply other threads:[~2018-11-16 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 19:33 [PATCH] RISC-V: recognize S/U mode bits in print_isa Patrick Stählin
2018-11-09 21:07 ` Palmer Dabbelt
2018-11-09 21:42 ` [PATCH v2] " Patrick Stählin
2018-11-16 16:52 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-e9ecd06a-7b9c-4b0f-af31-2c4c3b64c1a5@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=me@packi.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).