From: Palmer Dabbelt <palmer@sifive.com>
To: yamada.masahiro@socionext.com
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kbuild@vger.kernel.org, sam@ravnborg.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
corbet@lwn.net, michal.lkml@markovi.net
Subject: Re: [PATCH 2/3] kbuild: generate asm-generic wrappers if mandatory headers are missing
Date: Tue, 11 Dec 2018 08:29:53 -0800 (PST) [thread overview]
Message-ID: <mhng-f63eb098-71bf-411a-9583-388234647f1e@palmer-si-x1c4> (raw)
In-Reply-To: <CAK7LNAS7hh4f8mYoZc7RUWStnchhftUN0nU5MJ_trjyNJx50Lw@mail.gmail.com>
On Tue, 11 Dec 2018 04:59:26 PST (-0800), yamada.masahiro@socionext.com wrote:
> Hi Christoph,
>
>
> On Fri, Dec 7, 2018 at 12:04 AM Christoph Hellwig <hch@infradead.org> wrote:
>>
>> On Wed, Dec 05, 2018 at 08:28:05PM +0900, Masahiro Yamada wrote:
>> > Some time ago, Sam pointed out a certain degree of overwrap between
>> > generic-y and mandatory-y. (https://lkml.org/lkml/2017/7/10/121)
>> >
>> > I a bit tweaked the meaning of mandatory-y; now it defines the minimum
>> > set of ASM headers that all architectures must have.
>> >
>> > If arch does not have specific implementation of a mandatory header,
>> > Kbuild will let it fallback to the asm-generic one by automatically
>> > generating a wrapper. This will allow to drop lots of redundant
>> > generic-y defines.
>> >
>> > Previously, "mandatory" was used in the context of UAPI, but I guess
>> > this can be extended to kernel space ASM headers.
>>
>> How useful is it to keep the generic-y behavior around at all vs making
>> everything useful mandatory?
>
>
> What I can tell is not all architectures
> support kvm_para.h, ucontext.h
>
> I guess they will stay as arch-specific generic-y,
> but I am not an expert in this area.
>
>
> kvm_para.h is missing csky, nds32, riscv.
It looks like RISC-V missed it and everyone else copied us. I don't see any
reason why the generic version wouldn't work on RISC-V, as it just has failures
for all the calls.
> ucontext.h is missing in alpha, arm, m68k, parisc, sparc, xtensa
>
>
>
> bpf_perf_event.h could be promoted to mandatory-y ?
> All architectures have it.
next prev parent reply other threads:[~2018-12-11 16:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 11:28 [PATCH 1/3] kbuild: refactor Makefile.asm-generic Masahiro Yamada
2018-12-05 11:28 ` [PATCH 2/3] kbuild: generate asm-generic wrappers if mandatory headers are missing Masahiro Yamada
2018-12-06 15:03 ` Christoph Hellwig
2018-12-11 12:59 ` Masahiro Yamada
2018-12-11 16:29 ` Palmer Dabbelt [this message]
2018-12-06 18:04 ` Sam Ravnborg
2018-12-11 13:01 ` Masahiro Yamada
2018-12-16 15:24 ` [PATCH 1/3] kbuild: refactor Makefile.asm-generic Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-f63eb098-71bf-411a-9583-388234647f1e@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=corbet@lwn.net \
--cc=hch@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=sam@ravnborg.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).