From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754765AbdFXApg (ORCPT ); Fri, 23 Jun 2017 20:45:36 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35588 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754336AbdFXApY (ORCPT ); Fri, 23 Jun 2017 20:45:24 -0400 Date: Fri, 23 Jun 2017 17:45:23 -0700 (PDT) X-Google-Original-Date: Fri, 23 Jun 2017 17:38:46 PDT (-0700) From: Palmer Dabbelt To: Arnd Bergmann CC: geert@linux-m68k.org CC: linux-arch@vger.kernel.org CC: linux-kernel@vger.kernel.org CC: Olof Johansson CC: albert@sifive.com CC: patches@groups.riscv.org CC: gregkh@linuxfoundation.org CC: jslaby@suse.com CC: linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 12/17] tty: New RISC-V SBI Console Driver In-Reply-To: Message-ID: Mime-Version: 1.0 (MHng) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 07 Jun 2017 00:58:04 PDT (-0700), Arnd Bergmann wrote: > On Wed, Jun 7, 2017 at 9:15 AM, Geert Uytterhoeven wrote: >> CC (hypervisor) console folks >> >> On Wed, Jun 7, 2017 at 1:00 AM, Palmer Dabbelt wrote: >>> This patch adds a new driver for the console availiable via the RISC-V >>> SBI. This console is specified to be used for early boot messages, and >>> is designed to be a very simple (albiet somewhat slow) console that is >>> always availiable. All RISC-V systems have an SBI console. >>> >>> The SBI console is made availiable for early printk messages and is also >>> availiable as a regular console. >>> >>> Signed-off-by: Palmer Dabbelt >>> --- >>> drivers/tty/hvc/Kconfig | 11 +++++ >>> drivers/tty/hvc/Makefile | 1 + >>> drivers/tty/hvc/hvc_sbi.c | 102 ++++++++++++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 114 insertions(+) >>> create mode 100644 drivers/tty/hvc/hvc_sbi.c >>> >>> diff --git a/drivers/tty/hvc/Kconfig b/drivers/tty/hvc/Kconfig >>> index 574da15fe618..f3774adab240 100644 >>> --- a/drivers/tty/hvc/Kconfig >>> +++ b/drivers/tty/hvc/Kconfig >>> @@ -114,4 +114,15 @@ config HVCS >>> which will also be compiled when this driver is built as a >>> module. >>> >>> +config HVC_SBI >>> + bool "SBI console support" >>> + depends on RISCV >>> + select HVC_DRIVER >>> + default y >>> + help >>> + This enables support for console output via RISC-V SBI calls, which >>> + is normally used only during boot to output printk. >>> + >>> + If you don't know what do to here, say Y. >>> + >>> endif # TTY > > Please move this a little higher along with the other HVC_DRIVER > implementations. OK: https://github.com/riscv/riscv-linux/commit/1c769cad7931b7b08644d2d4a7b6985777a8e0be >>> + * RISC-V SBI interface to hvc_console.c >>> + * based on drivers-tty/hvc/hvc_udbg.c >>> + * >>> + * Copyright (C) 2008 David Gibson, IBM Corporation >>> + * Copyright (C) 2012 Regents of the University of California > > 2017? https://github.com/riscv/riscv-linux/commit/dafa678d26886076a8a9cccc2486f1bbbfa44aa8