linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Youngs <sryoungs@bigpond.net.au>
To: linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test11 -- Failed to open /dev/ttyS0: No such device
Date: Mon, 01 Dec 2003 12:17:14 +1000	[thread overview]
Message-ID: <microsoft-free.87vfp1nuxh.fsf@eicq.dnsalias.org> (raw)
In-Reply-To: 20031130222222.GA11809@finwe.eu.org

[-- Attachment #1: Type: text/plain, Size: 1762 bytes --]

|--==> "JK" == Jacek Kawa <jfk@zeus.polsl.gliwice.pl> writes:

  JK> Steve Youngs wrote:
  >>I _think_ this patch will bring back auto-loading of the serial module
  >>for you.  Please let me know how it goes. 

  JK> Well: patched, installed new serial_core.ko, then depmod -a, and
  JK> try to access ttySwhatever.

As Russell said, the patch was wrong, revert it.  Sorry about that, my
bad.  I really shouldn't try to hack the kernel late at night while
I'm hacking other things at the same time.

I'm pretty sure that the problem has its roots in...

diff -Nru a/fs/char_dev.c b/fs/char_dev.c
--- a/fs/char_dev.c	Sun Nov 23 17:33:38 2003
+++ b/fs/char_dev.c	Sun Nov 23 17:33:38 2003
@@ -434,7 +434,7 @@
 
 static struct kobject *base_probe(dev_t dev, int *part, void *data)
 {
-	request_module("char-major-%d", MAJOR(dev));
+	request_module("char-major-%d-%d", MAJOR(dev), MINOR(dev));
 	return NULL;
 }

...from Rusty, which went into 2.6.0-test10.

Does this work any better?

--- linux-2.6.0-test11/drivers/serial/8250.c	2003-11-27 11:03:42.000000000 +1000
+++ linux-2.6.0-test11-sy/drivers/serial/8250.c	2003-12-01 11:40:44.000000000 +1000
@@ -34,6 +34,7 @@
 #include <linux/serial.h>
 #include <linux/serialP.h>
 #include <linux/delay.h>
+#include <linux/device.h>
 
 #include <asm/io.h>
 #include <asm/irq.h>
@@ -2195,3 +2196,4 @@
 MODULE_PARM(force_rsa, "1-" __MODULE_STRING(PORT_RSA_MAX) "i");
 MODULE_PARM_DESC(force_rsa, "Force I/O ports for RSA");
 #endif
+MODULE_ALIAS_CHARDEV_MAJOR(TTY_MAJOR);



-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|              Ashes to ashes, dust to dust.               |
|      The proof of the pudding, is under the crust.       |
|------------------------------<sryoungs@bigpond.net.au>---|

[-- Attachment #2: Type: application/pgp-signature, Size: 256 bytes --]

  reply	other threads:[~2003-12-01  2:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-30  7:17 2.6.0-test11 -- Failed to open /dev/ttyS0: No such device William Park
2003-11-30 10:23 ` bert hubert
2003-11-30 11:36   ` Jacek Kawa
2003-11-30 15:54     ` Steve Youngs
2003-11-30 16:00       ` Russell King
2003-11-30 22:22       ` Jacek Kawa
2003-12-01  2:17         ` Steve Youngs [this message]
2003-12-01  7:28           ` Jacek Kawa
2003-11-30 19:05     ` William Park
2003-11-30 18:40   ` William Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=microsoft-free.87vfp1nuxh.fsf@eicq.dnsalias.org \
    --to=sryoungs@bigpond.net.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).