From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752874AbbGIHHt (ORCPT <rfc822;w@1wt.eu>);
	Thu, 9 Jul 2015 03:07:49 -0400
Received: from cantor2.suse.de ([195.135.220.15]:51626 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752002AbbGIHHn convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 9 Jul 2015 03:07:43 -0400
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Pali =?utf-8?Q?Roh=C3=A1r?= <pali.rohar@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
        "Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH] power: bq27x00_battery: Destroy battery_id IDR on module exit
References: <1436368700-30852-1-git-send-email-jthumshirn@suse.de>
	<201507081810.14511@pali>
Date: Thu, 09 Jul 2015 09:07:40 +0200
In-Reply-To: <201507081810.14511@pali> ("Pali \=\?utf-8\?Q\?Roh\=C3\=A1r\=22's\?\=
 message of "Wed, 8 Jul
	2015 18:10:14 +0200")
Message-ID: <mqdwpy9stab.fsf@c203.arch.suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Pali Rohár <pali.rohar@gmail.com> writes:

> On Wednesday 08 July 2015 17:18:20 Johannes Thumshirn wrote:
>> Destroy battery_id IDR on module exit, reclaiming the allocated
>> memory.
>> 
>> This was detected by the following semantic patch (written by Luis
>> Rodriguez <mcgrof@suse.com>)
>> <SmPL>
>> @ defines_module_init @
>> declarer name module_init, module_exit;
>> declarer name DEFINE_IDR;
>> identifier init;
>> @@
>> 
>> module_init(init);
>> 
>> @ defines_module_exit @
>> identifier exit;
>> @@
>> 
>> module_exit(exit);
>> 
>> @ declares_idr depends on defines_module_init && defines_module_exit
>> @ identifier idr;
>> @@
>> 
>> DEFINE_IDR(idr);
>> 
>> @ on_exit_calls_destroy depends on declares_idr &&
>> defines_module_exit @ identifier declares_idr.idr,
>> defines_module_exit.exit;
>> @@
>> 
>> exit(void)
>> {
>>  ...
>>  idr_destroy(&idr);
>>  ...
>> }
>> 
>> @ missing_module_idr_destroy depends on declares_idr &&
>> defines_module_exit && !on_exit_calls_destroy @ identifier
>> declares_idr.idr, defines_module_exit.exit;
>> @@
>> 
>> exit(void)
>> {
>>  ...
>>  +idr_destroy(&idr);
>> }
>> </SmPL>
>> 
>> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
>> ---
>>  drivers/power/bq27x00_battery.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/power/bq27x00_battery.c
>> b/drivers/power/bq27x00_battery.c index b6b9837..99180d2 100644
>> --- a/drivers/power/bq27x00_battery.c
>> +++ b/drivers/power/bq27x00_battery.c
>> @@ -1106,6 +1106,7 @@ static void __exit bq27x00_battery_exit(void)
>>  {
>>  	bq27x00_battery_platform_exit();
>>  	bq27x00_battery_i2c_exit();
>> +	idr_destroy(&battery_id);
>>  }
>>  module_exit(bq27x00_battery_exit);
>
> Hello, I see that none power supply kernel driver is calling 
> idr_destroy() at module exit time. So if this patch is needed for 
> bq27x00_battery module, then it is needed also for other charger/battery 
> modules...

You're right. I'll post a follow up for this with (this time hopefully)
all battery drivers included.

-- 
Johannes Thumshirn                                       Storage
jthumshirn@suse.de                             +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)