From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B76DC83F11 for ; Mon, 28 Aug 2023 12:42:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230335AbjH1MmK (ORCPT ); Mon, 28 Aug 2023 08:42:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbjH1Mln (ORCPT ); Mon, 28 Aug 2023 08:41:43 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C38C3E5; Mon, 28 Aug 2023 05:41:39 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-50098cc8967so5021419e87.1; Mon, 28 Aug 2023 05:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693226498; x=1693831298; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=35Zvmo59YN6o3oPAuxnrM8DnmGEhpgbLp58kB3g9lGU=; b=KSxh1ke+AfqK9ORplGlqm3Eit0KfK+YhWYLVMtxDY4buQMStb0+QJsms3Ku6pCvCbC GLw0DNyl5PcYzZzILkUqyYmoblod2u44FftEatXPsjyxp0rKRN3KJN3cvmQSMslbQoSl xJUNbaidTzygQRF1ChfqgNP/kPG/TQ8O8sPo7rU38PTY3JQLH8+DCsAjl+x1p871cbZm feRtMbwgiApiSCfvZ3axD0O4iG4b1vAfy6vSB83CuXdDp9121EI+OoTFcYDHyiQNgM83 qBom01b8lnIiexli8boD9pmqBjvpE/XFzvJx/gomDD0p/BKeIvJ9DxzdmBpR1jxbUK47 VS9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693226498; x=1693831298; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=35Zvmo59YN6o3oPAuxnrM8DnmGEhpgbLp58kB3g9lGU=; b=TNNpZnsj8iz5DKcYa7h8ZTdPeSe7N9/1356QnljzEzmfqU4lMmkRZ4eMAkeWzpKBOZ 49QkV0woy17bkmzEV8J7dmmRdxIFxxEzzBfroyJ3G/6OjUHy4vyWnpXInrWxPT1b3OZp n+aQI5wMJPMNGG6Pxu2GNiQlTPEAiPiyUizhWzupAVOzzQraoM/DLsZi1k2X6WADQx3p h4TYn5g8IzJ0xrxbn/WNFy6tL22scMNgEchtQziwk6EfSfZF6htnNzl0WshzbLsAs8XQ lIVhiVtkDjjh1gtMaDub9TZMMkaEERVmQkNj6wwKptkWnLJkxxZB5DdBAxnPJ2TxoDXZ 6+rw== X-Gm-Message-State: AOJu0YwxCOqr/iyRYHjEOpab62CUcSkKi+SSDdGbx0XVFNtvP5nKHVbD 1uJGuhVPfdUXNEoOxSZzQeQ= X-Google-Smtp-Source: AGHT+IFRlAtGX0zI23L+HPcaLdtS//sAFD2U7kQ3HH8Hea5Ggh0g2kh1a/yBtz8lEpewXjLli0HgGg== X-Received: by 2002:a05:6512:2203:b0:4fe:2d93:2b50 with SMTP id h3-20020a056512220300b004fe2d932b50mr22395653lfu.31.1693226497635; Mon, 28 Aug 2023 05:41:37 -0700 (PDT) Received: from mobilestation ([178.176.56.174]) by smtp.gmail.com with ESMTPSA id i22-20020ac25236000000b004ff981955cesm1568114lfl.228.2023.08.28.05.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Aug 2023 05:41:37 -0700 (PDT) Date: Mon, 28 Aug 2023 15:41:35 +0300 From: Serge Semin To: Krzysztof Kozlowski Cc: Keguang Zhang , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thomas Bogendoerfer , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Serge Semin Subject: Re: [PATCH v3 2/4] dt-bindings: net: Add Loongson-1 Ethernet Controller Message-ID: References: <20230824125012.1040288-1-keguang.zhang@gmail.com> <20230824125012.1040288-3-keguang.zhang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 28, 2023 at 09:15:17AM +0200, Krzysztof Kozlowski wrote: > On 27/08/2023 23:01, Serge Semin wrote: > > Hi Krzysztof > > > > On Sun, Aug 27, 2023 at 09:56:06AM +0200, Krzysztof Kozlowski wrote: > >> On 26/08/2023 23:04, Serge Semin wrote: > >>>> + clock-names: > >>>> + items: > >>>> + - const: stmmaceth > >>> > >>> clock-names: > >>> const: stmmaceth > >>> ? > >> > > > >> The existing syntax is correct. This is a string array. > > > > Could you please clarify whether it's a requirement (always specify > > items: property for an array) or just an acceptable option (another > > one is suggested in my comment)? I am asking because: > > 1. In this case the "clock-names" array is supposed to have only one > > item. Directly setting "const: stmmaceth" with no items: property > > shall simplify it. > > 2. There are single-entry "clock-names" property in the DT-bindings > > defined as I suggested. > > 3. There is a "compatible" property which is also a string array but > > it can be defined as I suggested (omitting the items property). > > > > so based on all of that using the "items:"-based constraint here seems > > redundant. Am I wrong to think like that? If so in what aspect? > > Syntax is correct in both cases. However the single list compatible > *cannot grow*, while single list clock might, when developer notices > that the binding was incomplete. People add binding matching drivers, > not the hardware, thus having incomplete list of clocks is happening all > the time. So it's just a matter of maintainability. Got it. Thanks. -Serge(y) > > Best regards, > Krzysztof >