From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E07CBC282CB for ; Tue, 5 Feb 2019 17:43:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF7312081B for ; Tue, 5 Feb 2019 17:43:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728299AbfBERnN (ORCPT ); Tue, 5 Feb 2019 12:43:13 -0500 Received: from mx2.suse.de ([195.135.220.15]:58018 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726534AbfBERnM (ORCPT ); Tue, 5 Feb 2019 12:43:12 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 84AF2B60D; Tue, 5 Feb 2019 17:43:11 +0000 (UTC) From: Andreas Schwab To: Paul Walmsley Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, paul@pwsan.com, palmer@sifive.com, aou@eecs.berkeley.edu Subject: Re: [PATCH] arch: riscv: support kernel command line forcing when no DTB passed References: X-Yow: OKAY!! Turn on the sound ONLY for TRYNEL CARPETING, FULLY-EQUIPPED R.V.'S and FLOATATION SYSTEMS!! Date: Tue, 05 Feb 2019 18:43:10 +0100 In-Reply-To: (Paul Walmsley's message of "Mon, 17 Dec 2018 19:15:12 -0800 (PST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Dez 17 2018, Paul Walmsley wrote: > diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c > index 2c290e6aaa6e..e6b962ff39b1 100644 > --- a/arch/riscv/kernel/setup.c > +++ b/arch/riscv/kernel/setup.c > @@ -171,7 +171,14 @@ asmlinkage void __init setup_vm(void) > > void __init parse_dtb(unsigned int hartid, void *dtb) > { > - early_init_dt_scan(__va(dtb)); > + if (!early_init_dt_scan(__va(dtb))) > + return; > + > + pr_err("No DTB passed to the kernel\n"); Isn't that backwards? early_init_dt_scan returns true if it found a DTB. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."