From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45A5DC46466 for ; Tue, 20 Nov 2018 11:40:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FA732087E for ; Tue, 20 Nov 2018 11:39:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FA732087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729392AbeKTWIi (ORCPT ); Tue, 20 Nov 2018 17:08:38 -0500 Received: from mx2.suse.de ([195.135.220.15]:60888 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728997AbeKTWIi (ORCPT ); Tue, 20 Nov 2018 17:08:38 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6ECCDAEC0; Tue, 20 Nov 2018 11:39:53 +0000 (UTC) From: Andreas Schwab To: Andrew Lunn Cc: Alexandre Belloni , Quentin Schulz , davem@davemloft.net, f.fainelli@gmail.com, allan.nielsen@microchip.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, thomas.petazzoni@bootlin.com, linux-riscv@lists.infradead.org Subject: Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions References: <20181008100728.24959-1-quentin.schulz@bootlin.com> <20181008100728.24959-2-quentin.schulz@bootlin.com> <20181119151057.GC26852@lunn.ch> <20181119152830.GE26852@lunn.ch> <20181119154005.GA8367@piout.net> <20181119161204.GC2393@lunn.ch> X-Yow: Jesus is my POSTMASTER GENERAL.. Date: Tue, 20 Nov 2018 12:39:51 +0100 In-Reply-To: <20181119161204.GC2393@lunn.ch> (Andrew Lunn's message of "Mon, 19 Nov 2018 17:12:04 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Nov 19 2018, Andrew Lunn wrote: > I still don't see why that would cause a hang. [ 996.370000] [] mutex_lock+0x22/0x2a [ 996.380000] [] mdiobus_read+0x36/0x60 [ 996.380000] [] vsc85xx_config_init+0x4c/0x1e2 vsc85xx_config_init is calling mdiobus_read while holding the mdio_lock. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."