From: Andreas Schwab <schwab@suse.de>
To: "Zhangjian \(Bamvor\)" <bamvor.zhangjian@huawei.com>
Cc: Yury Norov <ynorov@caviumnetworks.com>, <arnd@arndb.de>,
<catalin.marinas@arm.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-arch@vger.kernel.org>, <libc-alpha@sourceware.org>,
<schwidefsky@de.ibm.com>, <heiko.carstens@de.ibm.com>,
<pinskia@gmail.com>, <broonie@kernel.org>,
<joseph@codesourcery.com>,
<christoph.muellner@theobroma-systems.com>,
<szabolcs.nagy@arm.com>, <klimov.linux@gmail.com>,
<Nathan_Lynch@mentor.com>, <agraf@suse.de>,
<Prasun.Kapoor@caviumnetworks.com>, <kilobyte@angband.pl>,
<geert@linux-m68k.org>, <philipp.tomsich@theobroma-systems.com>,
<manuel.montezelo@gmail.com>, <linyongting@huawei.com>,
<maxim.kuvyrkov@linaro.org>, <davem@davemloft.net>,
Andrew Pinski <Andrew.Pinski@caviumnetworks.com>
Subject: Re: [PATCH 08/19] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat)
Date: Tue, 21 Jun 2016 13:34:59 +0200 [thread overview]
Message-ID: <mvmk2hipyfw.fsf@hawking.suse.de> (raw)
In-Reply-To: <576915B0.5040706@huawei.com> (Zhangjian's message of "Tue, 21 Jun 2016 18:23:44 +0800")
"Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> writes:
>> @@ -78,9 +79,9 @@
>>
>> #ifdef CONFIG_COMPAT
>> #define TASK_SIZE_32 UL(0x100000000)
>> -#define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \
>> +#define TASK_SIZE (is_compat_task() ? \
>> TASK_SIZE_32 : TASK_SIZE_64)
>> -#define TASK_SIZE_OF(tsk) (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
>> +#define TASK_SIZE_OF(tsk) (is_compat_thread(tsk) ? \
> It should be
> +#define TASK_SIZE_OF(tsk) (is_compat_thread(task_thread_info(tsk)) ? \
> is_compat_thread takes "struct thread_info *thread" while TASK_SIZE_OF takes
> "struct task_struct *tsk"tsk.
If that doesn't throw an error does that mean that TASK_SIZE_OF is
unused?
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2016-06-21 11:56 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 23:54 [RFC nowrap: PATCH v7 00/19] ILP32 for ARM64 Yury Norov
2016-06-17 23:54 ` [PATCH 01/19] compat ABI: use non-compat openat and open_by_handle_at variants Yury Norov
2016-06-27 7:47 ` Andreas Schwab
2016-08-15 14:30 ` Yury Norov
2016-08-25 15:52 ` Arnd Bergmann
2016-08-29 8:43 ` Yury Norov
2016-06-17 23:54 ` [PATCH 02/19] 32-bit ABI: introduce ARCH_32BIT_OFF_T config option Yury Norov
2016-06-17 23:54 ` [PATCH 03/19] arm64: ilp32: add documentation on the ILP32 ABI for ARM64 Yury Norov
2016-06-17 23:54 ` [PATCH 04/19] arm64: ensure the kernel is compiled for LP64 Yury Norov
2016-06-17 23:54 ` [PATCH 05/19] arm64: rename COMPAT to AARCH32_EL0 in Kconfig Yury Norov
2016-08-11 7:35 ` Zhangjian (Bamvor)
2016-08-11 8:53 ` Arnd Bergmann
2016-08-11 14:50 ` Catalin Marinas
2016-08-11 15:16 ` Arnd Bergmann
2016-08-11 16:30 ` Catalin Marinas
2016-08-11 20:29 ` Arnd Bergmann
2016-08-12 14:36 ` Catalin Marinas
2016-08-13 15:17 ` Yury Norov
2016-08-15 9:38 ` Catalin Marinas
2016-06-17 23:54 ` [PATCH 06/19] arm64:uapi: set __BITS_PER_LONG correctly for ILP32 and LP64 Yury Norov
2016-06-17 23:54 ` [PATCH 07/19] thread: move thread bits accessors to separated file Yury Norov
2016-06-17 23:54 ` [PATCH 08/19] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Yury Norov
2016-06-21 10:23 ` Zhangjian (Bamvor)
2016-06-21 11:34 ` Andreas Schwab [this message]
2016-06-21 15:47 ` Arnd Bergmann
2016-06-17 23:54 ` [PATCH 09/19] arm64: ilp32: add is_ilp32_compat_{task,thread} and TIF_32BIT_AARCH64 Yury Norov
2016-06-17 23:54 ` [PATCH 10/19] arm64: introduce binfmt_elf32.c Yury Norov
2016-06-17 23:54 ` [PATCH 11/19] arm64: ilp32: introduce binfmt_ilp32.c Yury Norov
2016-06-17 23:54 ` [PATCH 12/19] arm64: ptrace: handle ptrace_request differently for aarch32 and ilp32 Yury Norov
2016-06-27 4:47 ` zhouchengming
2016-06-27 4:49 ` [PATCH] ilp32: fix {GET,SET}SIGMASK request for ptrace zhouchengming
2016-06-27 5:39 ` Yury Norov
2016-06-27 10:30 ` zhouchengming
2016-08-13 14:52 ` Yury Norov
2016-06-17 23:54 ` [PATCH 13/19] arm64: ilp32: share aarch32 syscall handlers Yury Norov
2016-06-17 23:54 ` [PATCH 14/19] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Yury Norov
2016-06-20 12:48 ` Yury Norov
2016-06-17 23:54 ` [PATCH 15/19] arm64: signal: share lp64 signal routines to ilp32 Yury Norov
2016-06-17 23:54 ` [PATCH 16/19] arm64: signal32: move ilp32 and aarch32 common code to separated file Yury Norov
2016-06-17 23:54 ` [PATCH 17/19] arm64: ilp32: introduce ilp32-specific handlers for sigframe and ucontext Yury Norov
2016-06-17 23:54 ` [PATCH 18/19] arm64:ilp32: add vdso-ilp32 and use for signal return Yury Norov
2016-06-20 14:54 ` Andreas Schwab
2016-08-13 14:54 ` Yury Norov
2016-06-17 23:54 ` [PATCH 19/19] arm64:ilp32: add ARM64_ILP32 to Kconfig Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmk2hipyfw.fsf@hawking.suse.de \
--to=schwab@suse.de \
--cc=Andrew.Pinski@caviumnetworks.com \
--cc=Nathan_Lynch@mentor.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=bamvor.zhangjian@huawei.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=heiko.carstens@de.ibm.com \
--cc=joseph@codesourcery.com \
--cc=kilobyte@angband.pl \
--cc=klimov.linux@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyongting@huawei.com \
--cc=manuel.montezelo@gmail.com \
--cc=maxim.kuvyrkov@linaro.org \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=pinskia@gmail.com \
--cc=schwidefsky@de.ibm.com \
--cc=szabolcs.nagy@arm.com \
--cc=ynorov@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).