From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E1FCC6377D for ; Thu, 22 Jul 2021 13:48:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 059C36135A for ; Thu, 22 Jul 2021 13:48:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232161AbhGVNIM (ORCPT ); Thu, 22 Jul 2021 09:08:12 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:52684 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231925AbhGVNIL (ORCPT ); Thu, 22 Jul 2021 09:08:11 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id D6A571FF11; Thu, 22 Jul 2021 13:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626961725; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x3k96SXurbZA48P/lkQgfDs83i+1PSmUbdDIzs21Buk=; b=GLK48/GszrvU+As+t6scAnp429XWaAf5xo9EJgBieqIKX/1uH3UlgRTGhRA0xG0EB3MAO4 9NgysuQjEPWqkUs9bPYyI1mjSz2sgmCE84hT0qOMyBSAOclcsVcff4VZ8gMYYk6AvvMoUz yvVm19gBlwQUDy9FQA2mDExqVr/y14g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626961725; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x3k96SXurbZA48P/lkQgfDs83i+1PSmUbdDIzs21Buk=; b=7BHweoDvpcHNiTFKeIONKKwb/azGwjmFmqmZx96BWWfSd5kzQJKOASeeMOwucQURuxTmck lA9UYZ8U56LffeDg== Received: from hawking.suse.de (hawking.suse.de [10.160.4.0]) by relay2.suse.de (Postfix) with ESMTP id C344FA46A1; Thu, 22 Jul 2021 13:48:45 +0000 (UTC) Received: by hawking.suse.de (Postfix, from userid 17005) id B0551445C89; Thu, 22 Jul 2021 15:48:45 +0200 (CEST) From: Andreas Schwab To: Marco Felsch Cc: broonie@kernel.org, linux-spi@vger.kernel.org, kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH] spi: update modalias_show after of_device_uevent_modalias support References: <20210525091003.18228-1-m.felsch@pengutronix.de> X-Yow: I've got to get these SNACK CAKES to NEWARK by DAWN!! Date: Thu, 22 Jul 2021 15:48:45 +0200 In-Reply-To: <20210525091003.18228-1-m.felsch@pengutronix.de> (Marco Felsch's message of "Tue, 25 May 2021 11:10:03 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 3ce6c9e2617e ("spi: add of_device_uevent_modalias support") is incomplete, as it didn't update the modalias_show function to generate the of: modalias string if available. Fixes: 3ce6c9e2617e ("spi: add of_device_uevent_modalias support") Signed-off-by: Andreas Schwab --- drivers/spi/spi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index c99181165321..e4dc593b1f32 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -58,6 +58,10 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf) const struct spi_device *spi = to_spi_device(dev); int len; + len = of_device_modalias(dev, buf, PAGE_SIZE); + if (len != -ENODEV) + return len; + len = acpi_device_modalias(dev, buf, PAGE_SIZE - 1); if (len != -ENODEV) return len; -- 2.32.0 -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."