From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751955AbcFUIYL (ORCPT ); Tue, 21 Jun 2016 04:24:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:51704 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634AbcFUIXp (ORCPT ); Tue, 21 Jun 2016 04:23:45 -0400 From: Andreas Schwab To: Yury Norov Cc: , , , , , , , , , , Subject: Re: [PATCH 23/27] [AARCH64] delouse input arguments in system functions References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com> <1466485631-3532-25-git-send-email-ynorov@caviumnetworks.com> X-Yow: Remember, if you try to ESCAPE, many APARTMENT HOPPING ALCOHOLICS will SIMONIZE your HALLWAYS!! This is your LAST WARNING!! Date: Tue, 21 Jun 2016 10:08:05 +0200 In-Reply-To: <1466485631-3532-25-git-send-email-ynorov@caviumnetworks.com> (Yury Norov's message of "Tue, 21 Jun 2016 08:07:07 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yury Norov writes: > diff --git a/sysdeps/aarch64/dl-tlsdesc.S b/sysdeps/aarch64/dl-tlsdesc.S > index fe8a17d..718dddf 100644 > --- a/sysdeps/aarch64/dl-tlsdesc.S > +++ b/sysdeps/aarch64/dl-tlsdesc.S > @@ -74,6 +74,7 @@ > cfi_startproc > .align 2 > _dl_tlsdesc_return: > + DELOUSE(0) > ldr PTR_REG (0), [x0, #PTR_SIZE] > RET > cfi_endproc > @@ -126,6 +127,7 @@ _dl_tlsdesc_undefweak: > td->entry in _dl_tlsdesc_resolve_rela_fixup ensuring that the load > from [x0,#8] here happens after the initialization of td->arg. */ > ldar xzr, [x0] > + DELOUSE(0) That needs to be moved before the previous insn, doesn't it? Also, again _dl_tlsdesc_return_lazy is missing. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."