From: Andrew Halaney <ahalaney@redhat.com>
To: Eric Chanudet <echanude@redhat.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: ufs: qcom: avoid re-init quirk when gears match
Date: Wed, 24 Jan 2024 07:55:18 -0600 [thread overview]
Message-ID: <mzfbayn2yz2egmtv2lankxn3h7p4pglaqxallczzmcevkvnp5b@jplxt7yu6xae> (raw)
In-Reply-To: <20240123192854.1724905-4-echanude@redhat.com>
On Tue, Jan 23, 2024 at 02:28:57PM -0500, Eric Chanudet wrote:
> On sa8775p-ride, probing the hba will go through the
> UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH path although the power info
> are same during the second init.
>
> The REINIT quirk only applies starting with controller v4. For these,
> ufs_qcom_get_hs_gear() reads the highest supported gear when setting the
> host_params. After the negotiation, if the host and device are on the
> same gear, it is the highest gear supported between the two. Skip REINIT
> to save some time.
>
> Signed-off-by: Eric Chanudet <echanude@redhat.com>
On the sa8775p-ride I have I see similar results to what you mention!
Thanks.
Tested-by: Andrew Halaney <ahalaney@redhat.com> # sa8775p-ride
> ---
>
> v1 -> v2:
> * drop test against host->hw_ver.major >= 4 and amend description as a
> result (Andrew/Mani)
> * add comment, test device gear against host->phy_gear and reset
> host->phy_gear only if necessary (Mani)
> * Link to v1: https://lore.kernel.org/linux-arm-msm/20240119185537.3091366-11-echanude@redhat.com/
>
> trace_event=ufs:ufshcd_init reports the time spent in ufshcd_probe_hba
> where the re-init quirk is performed:
> Currently:
> 0.355879: ufshcd_init: 1d84000.ufs: took 103377 usecs, dev_state: UFS_ACTIVE_PWR_MODE, link_state: UIC_LINK_ACTIVE_STATE, err 0
> With this patch:
> 0.297676: ufshcd_init: 1d84000.ufs: took 43553 usecs, dev_state: UFS_ACTIVE_PWR_MODE, link_state: UIC_LINK_ACTIVE_STATE, err 0
>
> drivers/ufs/host/ufs-qcom.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 39eef470f8fa..f7dba7236c6e 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -738,8 +738,17 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba,
> * the second init can program the optimal PHY settings. This allows one to start
> * the first init with either the minimum or the maximum support gear.
> */
> - if (hba->ufshcd_state == UFSHCD_STATE_RESET)
> - host->phy_gear = dev_req_params->gear_tx;
> + if (hba->ufshcd_state == UFSHCD_STATE_RESET) {
> + /*
> + * Skip REINIT if the negotiated gear matches with the
> + * initial phy_gear. Otherwise, update the phy_gear to
> + * program the optimal gear setting during REINIT.
> + */
> + if (host->phy_gear == dev_req_params->gear_tx)
> + hba->quirks &= ~UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH;
> + else
> + host->phy_gear = dev_req_params->gear_tx;
> + }
>
> /* enable the device ref clock before changing to HS mode */
> if (!ufshcd_is_hs_mode(&hba->pwr_info) &&
> --
> 2.43.0
>
>
next prev parent reply other threads:[~2024-01-24 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 19:28 [PATCH v2] scsi: ufs: qcom: avoid re-init quirk when gears match Eric Chanudet
2024-01-24 8:48 ` Manivannan Sadhasivam
2024-01-24 13:55 ` Andrew Halaney [this message]
2024-01-25 2:36 ` Martin K. Petersen
2024-01-30 2:27 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mzfbayn2yz2egmtv2lankxn3h7p4pglaqxallczzmcevkvnp5b@jplxt7yu6xae \
--to=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=echanude@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).