From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754372AbeDPJt6 (ORCPT ); Mon, 16 Apr 2018 05:49:58 -0400 Received: from mx2.suse.de ([195.135.220.15]:56086 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204AbeDPJt4 (ORCPT ); Mon, 16 Apr 2018 05:49:56 -0400 Date: Mon, 16 Apr 2018 11:49:54 +0200 (CEST) From: Jiri Kosina To: Robert Munteanu cc: Benjamin Tissoires , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard In-Reply-To: <20180411094953.12053-1-rombert@apache.org> Message-ID: References: <20180411094953.12053-1-rombert@apache.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Apr 2018, Robert Munteanu wrote: > Changelog: > > - v2: modifier keys work, some combinations are still troublesome > - v3: style cleanup, rebase on top of 4.14 > - v4: remove most debugging calls, make init info useful for user, > rebased on top of 4.15 > - v5: fix the HID descriptor as suggested by Benjamin Tissoires, > use existing USB vendor id, update comment style, add SPDX > license identifier, rename to hid-redragon, stop registering > two input devices, rebased on top of 4.16 This should contain the text that goes directly into the git commit changelog, therefore should instead contain something like "This adds a news driver for HW XX, that needs a specialized driver bacuse .... and things to specifically point out in implementation are ....". Could you please provide that, so that I can commit it? Thanks. -- Jiri Kosina SUSE Labs