From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B31CC10F13 for ; Tue, 16 Apr 2019 20:31:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D22720868 for ; Tue, 16 Apr 2019 20:31:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555446696; bh=guNqNmDD90m6Dxpy5lwwkbAOV+qQQDQzRqzAmRH6YIY=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=WGrgHmiUrIoOh894rV2cUA2XmQnduWMVzf/t2Q9l9U+rNnt4gDiv3gzfT/opIMwiZ PSFdKHlhjjQpPfHSZbyTsATYLiRdp5nTxZkRTVWlbuT5mYWezefZPq56UPfE8xb8xX ZfxHbmpVraDFpmrcdoR/W9uvGARxqiKqhmO0jlBI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730723AbfDPUbf (ORCPT ); Tue, 16 Apr 2019 16:31:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:37908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728466AbfDPUbe (ORCPT ); Tue, 16 Apr 2019 16:31:34 -0400 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BCBAC20663; Tue, 16 Apr 2019 20:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555446693; bh=guNqNmDD90m6Dxpy5lwwkbAOV+qQQDQzRqzAmRH6YIY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=rrVovOzUYGfP61k5urmNDdXALZi/woXaMj2Scx68wYp07N6NQVVJo6WjBL7MXozQR zlJ3I4IErCi92KnrUW0cPNPoTw5fEhmoBu8zERbmdDlmr6fQDljhTsKgWnePw5ojdt 3kgROB3+0M12LauMWlIf3+eIZqMo2Blkb2GHCnkQ= Date: Tue, 16 Apr 2019 22:31:24 +0200 (CEST) From: Jiri Kosina To: Arnd Bergmann cc: Alexander Viro , linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jarkko Sakkinen , Jason Gunthorpe , Sudip Mukherjee , Peter Huewe , Jason Gunthorpe , Stefan Richter , Benjamin Tissoires , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Tomas Winkler , Artem Bityutskiy , Richard Weinberger , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , "David S. Miller" , Alex Williamson , "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , OGAWA Hirofumi , Willem de Bruijn , linux-integrity@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-usb@vger.kernel.org, linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v3 09/26] compat_ioctl: move drivers to compat_ptr_ioctl In-Reply-To: <20190416202013.4034148-10-arnd@arndb.de> Message-ID: References: <20190416202013.4034148-1-arnd@arndb.de> <20190416202013.4034148-10-arnd@arndb.de> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Apr 2019, Arnd Bergmann wrote: > Each of these drivers has a copy of the same trivial helper function to > convert the pointer argument and then call the native ioctl handler. > > We now have a generic implementation of that, so use it. > > Acked-by: Greg Kroah-Hartman > Reviewed-by: Jarkko Sakkinen > Reviewed-by: Jason Gunthorpe > Signed-off-by: Arnd Bergmann > --- > drivers/char/ppdev.c | 12 +--------- > drivers/char/tpm/tpm_vtpm_proxy.c | 12 +--------- > drivers/firewire/core-cdev.c | 12 +--------- > drivers/hid/usbhid/hiddev.c | 11 +-------- For hiddev.c: Reviewed-by: Jiri Kosina -- Jiri Kosina SUSE Labs