From: Jiri Kosina <jikos@kernel.org>
To: Fabien Dessenne <fabien.dessenne@st.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: rmi: fix devm_add_action_or_reset() parameter
Date: Fri, 3 May 2019 14:19:19 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.1905031418510.10635@cbobk.fhfr.pm> (raw)
In-Reply-To: <1555073657-24386-1-git-send-email-fabien.dessenne@st.com>
On Fri, 12 Apr 2019, Fabien Dessenne wrote:
> The second parameter of devm_add_action_or_reset() shall be a function,
> not a function address.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> ---
> drivers/hid/hid-rmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
> index 9e33165..8748d4d 100644
> --- a/drivers/hid/hid-rmi.c
> +++ b/drivers/hid/hid-rmi.c
> @@ -623,7 +623,7 @@ static int rmi_setup_irq_domain(struct hid_device *hdev)
> if (!hdata->domain)
> return -ENOMEM;
>
> - ret = devm_add_action_or_reset(&hdev->dev, &rmi_irq_teardown, hdata);
> + ret = devm_add_action_or_reset(&hdev->dev, rmi_irq_teardown, hdata);
Why do you think this is wrong C?
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2019-05-03 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 12:54 [PATCH] HID: rmi: fix devm_add_action_or_reset() parameter Fabien Dessenne
2019-05-03 12:19 ` Jiri Kosina [this message]
2019-05-03 12:38 ` Fabien DESSENNE
2019-05-03 12:42 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1905031418510.10635@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=fabien.dessenne@st.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).