From: Jiri Kosina <jikos@kernel.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Hans de Goede <hdegoede@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing <linux-kernel@vger.kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org
Subject: Re: Strange regression in hid_llogitech_dj (was: Re: Linux 5.2-rc4)
Date: Wed, 12 Jun 2019 00:02:21 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.1906112358580.27227@cbobk.fhfr.pm> (raw)
In-Reply-To: <2268131.Lc39eCoc3j@kreacher>
On Tue, 11 Jun 2019, Rafael J. Wysocki wrote:
> I noticed that the cordless mouse used by me with one of the machines here
> stopped to work in 5.2-rc (up to and including the -rc4).
>
> Bisection turned up commit 74808f9115ce ("HID: logitech-dj: add support for non
> unifying receivers").
>
> Of course, that commit does not revert cleanly from 5.2-rc4, but I have reverted
> the changes made by it in hid/hid-ids.h and I took the version of hid/hid-logitech-dj.c
> from commit b6aeeddef68d ("HID: logitech-dj: add logi_dj_recv_queue_unknown_work
> helper"), which is the parent of commit 74808f9115ce, and that made the mouse
> work again for me.
>
> Here's the output of "dmesg | grep -i logitech" from 5.2-rc4 with the above changes:
>
> [ 4.288905] usb 1-2: Manufacturer: Logitech
> [ 5.444621] input: Logitech USB Receiver as /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.0/0003:046D:C52F.0002/input/input23
> [ 5.446960] hid-generic 0003:046D:C52F.0002: input,hidraw1: USB HID v1.11 Mouse [Logitech USB Receiver] on usb-0000:00:14.0-2/input0
> [ 5.451265] input: Logitech USB Receiver Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.1/0003:046D:C52F.0003/input/input24
> [ 5.507545] hid-generic 0003:046D:C52F.0003: input,hiddev96,hidraw2: USB HID v1.11 Device [Logitech USB Receiver] on usb-0000:00:14.0-2/input1
Hi Rafael,
0x046d/0xc52f is known to have issues in 5.2-rcX. There is a patch queued
[1] that is believed to fix all this; my plan is to send it to Linus in
the coming 1-2 days. If you could report whether it fixes the issues
you've been seeing yourself as well, it'd be helpful.
Thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-5.2/fixes&id=3ed224e273ac5880eeab4c3043a6b06b0478dd56
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2019-06-11 22:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 3:46 Linux 5.2-rc4 Linus Torvalds
2019-06-09 8:15 ` Bhaskar Chowdhury
2019-06-11 21:53 ` Strange regression in hid_llogitech_dj (was: Re: Linux 5.2-rc4) Rafael J. Wysocki
2019-06-11 22:02 ` Jiri Kosina [this message]
2019-06-12 8:24 ` Rafael J. Wysocki
2019-06-12 8:31 ` Jiri Kosina
2019-06-12 8:51 ` Rafael J. Wysocki
2019-06-12 9:24 ` Jiri Kosina
2019-07-25 10:07 ` [Regression] 5.3-rc1: hid_llogitech_dj does not work Rafael J. Wysocki
2019-07-25 15:50 ` Hans de Goede
2019-07-29 15:49 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1906112358580.27227@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).