From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D7BCC31E44 for ; Tue, 11 Jun 2019 22:02:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E58D620874 for ; Tue, 11 Jun 2019 22:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560290547; bh=MhD+8y0ERq3GqD6GItAk03QOAWY9bjuZ5c18nOOYU54=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=YiHXEMuAJx58QUaDFH/UVnVh794WjyaiW8qQJ2TdvqRyPLRuk4uZ7kkEv4t7bN8Vi kAAJV4JTbu4nqXh6E6nsX+i/KR1bT5W7/5SFeO0WtHLocx5CjzyiJ+qnRA4JY8mJLQ v7I86+YZ4FiiKKNFJ172/oe9CsuCwiiQuWH79wpI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391989AbfFKWC0 (ORCPT ); Tue, 11 Jun 2019 18:02:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:43694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390411AbfFKWC0 (ORCPT ); Tue, 11 Jun 2019 18:02:26 -0400 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4A335205ED; Tue, 11 Jun 2019 22:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560290545; bh=MhD+8y0ERq3GqD6GItAk03QOAWY9bjuZ5c18nOOYU54=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=0cdiuYYP9Bq46e+NLG0whSnYoRshba1+vkbEMUEIQ+eMBdugDZUCoK7a7vYlu1umy 8S6XN1nymffu1xhvuhZA1FnHr+WKTbG0WinLGp/LwN8+R8QZDC/o6BOrNe2/3+ObR/ VmTTSzpnbdUz5pIUFH9VbXq88gcCGm4YHU5y/PBU= Date: Wed, 12 Jun 2019 00:02:21 +0200 (CEST) From: Jiri Kosina To: "Rafael J. Wysocki" cc: Hans de Goede , Linus Torvalds , Linux Kernel Mailing , Benjamin Tissoires , linux-input@vger.kernel.org Subject: Re: Strange regression in hid_llogitech_dj (was: Re: Linux 5.2-rc4) In-Reply-To: <2268131.Lc39eCoc3j@kreacher> Message-ID: References: <2268131.Lc39eCoc3j@kreacher> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Jun 2019, Rafael J. Wysocki wrote: > I noticed that the cordless mouse used by me with one of the machines here > stopped to work in 5.2-rc (up to and including the -rc4). > > Bisection turned up commit 74808f9115ce ("HID: logitech-dj: add support for non > unifying receivers"). > > Of course, that commit does not revert cleanly from 5.2-rc4, but I have reverted > the changes made by it in hid/hid-ids.h and I took the version of hid/hid-logitech-dj.c > from commit b6aeeddef68d ("HID: logitech-dj: add logi_dj_recv_queue_unknown_work > helper"), which is the parent of commit 74808f9115ce, and that made the mouse > work again for me. > > Here's the output of "dmesg | grep -i logitech" from 5.2-rc4 with the above changes: > > [ 4.288905] usb 1-2: Manufacturer: Logitech > [ 5.444621] input: Logitech USB Receiver as /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.0/0003:046D:C52F.0002/input/input23 > [ 5.446960] hid-generic 0003:046D:C52F.0002: input,hidraw1: USB HID v1.11 Mouse [Logitech USB Receiver] on usb-0000:00:14.0-2/input0 > [ 5.451265] input: Logitech USB Receiver Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.1/0003:046D:C52F.0003/input/input24 > [ 5.507545] hid-generic 0003:046D:C52F.0003: input,hiddev96,hidraw2: USB HID v1.11 Device [Logitech USB Receiver] on usb-0000:00:14.0-2/input1 Hi Rafael, 0x046d/0xc52f is known to have issues in 5.2-rcX. There is a patch queued [1] that is believed to fix all this; my plan is to send it to Linus in the coming 1-2 days. If you could report whether it fixes the issues you've been seeing yourself as well, it'd be helpful. Thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-5.2/fixes&id=3ed224e273ac5880eeab4c3043a6b06b0478dd56 -- Jiri Kosina SUSE Labs