From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C596C0650F for ; Mon, 5 Aug 2019 12:24:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D44ED2173B for ; Mon, 5 Aug 2019 12:24:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565007865; bh=Oj3FPFXjuZW8aPht4bbn3YgVA2X/7dkzPDjsNfH4nDc=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=heXbphw2+v34G3b6p9ON7028rbCuJvamDizyBUJiGW9eelYFtrAUO7LB3IbGRgywZ qBz49q4czccfVD0OSUiBl2W/3YwV7FDa5G26pRBQsWol1ytcs1MLIPAuZKuRFK0v6L XS5Prow9EbeBIdLy79onv4tg0hpNFNdOfoJwFS3s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728796AbfHEMYY (ORCPT ); Mon, 5 Aug 2019 08:24:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:58338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727259AbfHEMYY (ORCPT ); Mon, 5 Aug 2019 08:24:24 -0400 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F010020880; Mon, 5 Aug 2019 12:24:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565007863; bh=Oj3FPFXjuZW8aPht4bbn3YgVA2X/7dkzPDjsNfH4nDc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=rc67jfov6f45X1oYV0lXMBU96xnOstBh/8Wg3OI5C2o0BxO1BSdtBmM1vNkWAgIUc j5ly81QJ4W/0Ql98gioJ5SB8T2fIG2+a4Yr39gyADL5XXNwVZlAzInsYNL+gqU/XO7 ce4eHcUuZzytfdLwAUSSzalZLcr3vNXcdLp9ndLo= Date: Mon, 5 Aug 2019 14:24:18 +0200 (CEST) From: Jiri Kosina To: Hillf Danton cc: syzbot , andreyknvl@google.com, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: KASAN: use-after-free Read in hiddev_release In-Reply-To: <20190805081212.3144-1-hdanton@sina.com> Message-ID: References: <20190805081212.3144-1-hdanton@sina.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Aug 2019, Hillf Danton wrote: > 1, no dev no open. > > --- a/drivers/hid/usbhid/hiddev.c > +++ b/drivers/hid/usbhid/hiddev.c > @@ -284,6 +284,10 @@ static int hiddev_open(struct inode *ino > spin_unlock_irq(&list->hiddev->list_lock); > > mutex_lock(&hiddev->existancelock); > + if (!list->hiddev->exist) { > + res = -ENODEV; > + goto bail_unlock; > + } > if (!list->hiddev->open++) > if (list->hiddev->exist) { > struct hid_device *hid = hiddev->hid; > -- > > 2, list_del before vfree. > > --- a/drivers/hid/usbhid/hiddev.c > +++ b/drivers/hid/usbhid/hiddev.c > @@ -300,6 +304,9 @@ bail_normal_power: > hid_hw_power(hid, PM_HINT_NORMAL); > bail_unlock: > mutex_unlock(&hiddev->existancelock); > + spin_lock_irq(&list->hiddev->list_lock); > + list_del(&list->node); > + spin_unlock_irq(&list->hiddev->list_lock); > bail: > file->private_data = NULL; > vfree(list); Hilf, both patches look good to me. Could you please resend them properly so that I could apply them? Thanks, -- Jiri Kosina SUSE Labs