From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53100C49ED7 for ; Mon, 23 Sep 2019 09:09:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E10B21670 for ; Mon, 23 Sep 2019 09:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569229771; bh=8RVElTFHvsRrDX3GxYgPYspbtm5Sp3n+wmCjOPQwbZE=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=XFPedvwjgMDE7WFaQlsr+HoDogtjm6bkAa9U9GDY6aL2m7e54if1iO1XK00YBaQKT KZ5WCa2AJiPjpDqLyoEYmBt8zY1LDbKU22LkMcdBjCrstKqnu0lS4dDZ1y7EAbUmA2 LTWAtJnQ9sIY+fY1bYh30wayeyxOEgB1MnqCHmkA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732026AbfIWJJa (ORCPT ); Mon, 23 Sep 2019 05:09:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:34224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727935AbfIWJJ3 (ORCPT ); Mon, 23 Sep 2019 05:09:29 -0400 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 96D1721670; Mon, 23 Sep 2019 09:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569229769; bh=8RVElTFHvsRrDX3GxYgPYspbtm5Sp3n+wmCjOPQwbZE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=izQR+Ljq1dVwLHm5KTtNGF79NJ/EL5R2/ffn+GssEW54+zd0wsz29hRhL0v9QXlZO ZtnDw4hGhTU6Nxps/8cTsVxYJlr5IYqnFn4tBOoWyapkPYT8OkGeWQziHbYIsxm3AK AG1ay2GLq4BEHEmIUoghAJlf3e3cuz3Q3bZsGPNg= Date: Mon, 23 Sep 2019 11:09:04 +0200 (CEST) From: Jiri Kosina To: Dmitry Torokhov cc: Nicolas Boichat , Benjamin Tissoires , Benson Leung , "open list:HID CORE LAYER" , lkml Subject: Re: [PATCH 1/3] HID: google: whiskers: more robust tablet mode detection In-Reply-To: Message-ID: References: <20190913220317.58289-1-dtor@chromium.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 15 Sep 2019, Dmitry Torokhov wrote: > > > The USB interface may get detected before the platform/EC one, so let's > > > note the state of the base (if we receive event) and use it to correctly > > > initialize the tablet mode switch state. > > > > > > Also let's start the HID interface immediately when probing, this will > > > ensure that we correctly process "base folded" events that may be sent > > > as we initialize the base. Note that this requires us to add a release() > > > > s/release/remove/ ? > > You are right. I'll fix that up when I am applying it (once 5.4 merge window is over). Thanks, -- Jiri Kosina SUSE Labs