From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8D46C04E30 for ; Mon, 9 Dec 2019 12:53:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA8EC207FF for ; Mon, 9 Dec 2019 12:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575896000; bh=U4O5S5rduTkoz2GV1+PR+HzHG8x2XgOHHdNguUE9hoE=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=SDyWo08cUxTBCnJV+vPc4C6OHnifcAu4PMBgPWxXlnUT89RXhEmEXE59Ut2HfyPXY 3oTgOJh9O0O0MdJnRCrgnISYvygtlfWKfOwHxWtfMVougzEU213HK2/pIxxGqcdDDe 5hoAbEcIOlNw5IwVUwYVR6TxfjNTyzqCS8Zxh474= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727645AbfLIMxT (ORCPT ); Mon, 9 Dec 2019 07:53:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:59196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726687AbfLIMxT (ORCPT ); Mon, 9 Dec 2019 07:53:19 -0500 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C01192077B; Mon, 9 Dec 2019 12:53:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575895998; bh=U4O5S5rduTkoz2GV1+PR+HzHG8x2XgOHHdNguUE9hoE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=PuGahGg+Kxhi1BtiiL+cBFKGmrXbgDJx3hB3Idx5s1FkWMN3O147lxKPBnRf97WvQ pcMVDohclVKLlvNb8bzLWaOAXVARR5aXaA4w9tkYL1Q8kjjtLIHPEKaXhnHSxRHW3E lBSdMSXQPHDL/D72y1e6CwltG3ds8XMxk33M0j04= Date: Mon, 9 Dec 2019 13:53:15 +0100 (CET) From: Jiri Kosina To: Marcel Holtmann cc: Benjamin Tissoires , Fabian Henneke , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hidraw: Fix returning EPOLLOUT from hidraw_poll In-Reply-To: <20191204023713.3983-1-marcel@holtmann.org> Message-ID: References: <20191204023713.3983-1-marcel@holtmann.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Dec 2019, Marcel Holtmann wrote: > When polling a connected /dev/hidrawX device, it is useful to get the > EPOLLOUT when writing is possible. Since writing is possible as soon as > the device is connected, always return it. > > Right now EPOLLOUT is only returned when there are also input reports > are available. This works if devices start sending reports when > connected, but some HID devices might need an output report first before > sending any input reports. This change will allow using EPOLLOUT here as > well. > > Fixes: 378b80370aa1 ("hidraw: Return EPOLLOUT from hidraw_poll") > Signed-off-by: Marcel Holtmann > Cc: stable@vger.kernel.org Applied, thanks Marcel. -- Jiri Kosina SUSE Labs