From: Jiri Kosina <jikos@kernel.org>
To: Tony Fischetti <tony.fischetti@gmail.com>
Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse
Date: Tue, 10 Mar 2020 12:53:21 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2003101251500.19500@cbobk.fhfr.pm> (raw)
In-Reply-To: <20200304164700.11574-1-tony.fischetti@gmail.com>
On Wed, 4 Mar 2020, Tony Fischetti wrote:
> A lenovo pixart mouse (17ef:608d) is afflicted common the the malfunction
> where it disconnects and reconnects every minute--each time incrementing
> the device number. This patch adds the device id of the device and
> specifies that it needs the HID_QUIRK_ALWAYS_POLL quirk in order to
> work properly.
You are missing Signed-off-by: line here (please see
Documentation/process/5.Posting.rst and
Documentation/process/submitting-patches.rst to read what this is about).
Also, we generally prefix all the patches to HID susbsytem with 'HID: ' in
the subject / shortlog, so as you'll be resending with signoff, could you
please fix that up at the same time as well?
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2020-03-10 11:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 16:47 [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse Tony Fischetti
2020-03-10 11:53 ` Jiri Kosina [this message]
2020-03-10 13:48 ` Filipe Laíns
2020-03-12 15:22 ` Tony Fischetti
2020-03-13 11:23 ` Jiri Kosina
2020-03-15 1:07 ` Tony Fischetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2003101251500.19500@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.fischetti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).