From: Jiri Kosina <jikos@kernel.org>
To: Lucas Tanure <tanure@linux.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] HID: appleir: Remove unnecessary goto label
Date: Fri, 13 Mar 2020 17:32:14 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2003131731490.19500@cbobk.fhfr.pm> (raw)
In-Reply-To: <7c4c591bc1aa9e269cbf764a03e64d32dd6e6e96.1582998175.git.tanure@linux.com>
On Sat, 29 Feb 2020, Lucas Tanure wrote:
> Signed-off-by: Lucas Tanure <tanure@linux.com>
> ---
> drivers/hid/hid-appleir.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hid/hid-appleir.c b/drivers/hid/hid-appleir.c
> index bf8d4afe0d6a..aafc285b538f 100644
> --- a/drivers/hid/hid-appleir.c
> +++ b/drivers/hid/hid-appleir.c
> @@ -284,10 +284,8 @@ static int appleir_probe(struct hid_device *hid, const struct hid_device_id *id)
> struct appleir *appleir;
>
> appleir = kzalloc(sizeof(struct appleir), GFP_KERNEL);
> - if (!appleir) {
> - ret = -ENOMEM;
> - goto allocfail;
> - }
> + if (!appleir)
> + return -ENOMEM;
>
> appleir->hid = hid;
>
> @@ -314,7 +312,6 @@ static int appleir_probe(struct hid_device *hid, const struct hid_device_id *id)
> return 0;
> fail:
> kfree(appleir);
> -allocfail:
> return ret;
> }
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2020-03-13 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-29 17:43 [PATCH 1/2] HID: appleir: Remove unnecessary goto label Lucas Tanure
2020-02-29 17:43 ` [PATCH 2/2] HID: appleir: Use devm_kzalloc() instead of kzalloc() Lucas Tanure
2020-03-13 16:32 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2003131731490.19500@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tanure@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).