From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 565CBC433E1 for ; Fri, 15 May 2020 10:26:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C47020759 for ; Fri, 15 May 2020 10:26:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589538371; bh=GjhxDA2RKzNeJYUxoTNiF+dY0Weh6A59Cpbsz/pBpIk=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=aPc8vuFdys3fYCPFiV2X4yDjxurDhO2+uFKoDVPKnVGyPiEce7xh5wiDOiXVDOUl7 IVw6VnU0CM+gYBOK1pUOsF/BXdByuGWTgBXh8iEfbIvNEZp9QD8UEp1h1MVXM1pxgY h0ImtdXvqfeZdTrWVeqYyPlDcqAGHuFeB6Z4saOQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728230AbgEOK0K (ORCPT ); Fri, 15 May 2020 06:26:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:40838 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728053AbgEOK0K (ORCPT ); Fri, 15 May 2020 06:26:10 -0400 Received: from pobox.suse.cz (nat1.prg.suse.com [195.250.132.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21BA6206B6; Fri, 15 May 2020 10:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589538370; bh=GjhxDA2RKzNeJYUxoTNiF+dY0Weh6A59Cpbsz/pBpIk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=u42J3Kar1lJV87G25ONXajxwDbeUaCc1+AaMMqWHhiuCHrTV5i6Vf6lPlhU1UDPv2 XUswIupYrY1FiN/Zn6MI6EpOtCiA2HCvobFLoOee0XTB4Buwha6dzTD9MhEnr0oVIv sYRf1D0emfeF2nkcSEo9FpBGPsZrJJQZa130Mauo= Date: Fri, 15 May 2020 12:26:07 +0200 (CEST) From: Jiri Kosina To: free5lot cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5.7-rc5] HID: apple: Swap the Fn and Left Control keys on Apple keyboards In-Reply-To: <27588684-a25a-83fd-7204-df3d6c20aac1@free5lot.com> Message-ID: References: <27588684-a25a-83fd-7204-df3d6c20aac1@free5lot.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 May 2020, free5lot wrote: > This patch allows users to swap the Fn and left Control keys on all Apple > keyboards: internal (e.g. Macbooks) and external (both wired and wireless). > The patch adds a new hid-apple module param: swap_fn_leftctrl (off by > default). > > Signed-off-by: Zakhar Semenov > --- > This patch was created to eliminate the inconvenience of having an unusual > order of 4 left-bottom keys on Apple keyboards for GNU+Linux users. > Now it's possible to swap the Fn and left Control keys on Macbooks and > external Apple keyboards and have the same experience as on usual PC layout. > > The patch has been heavily tested for about 5 years by community at: > https://github.com/free5lot/hid-apple-patched > The patch is small and straightforward. The modified version of hid-apple > is currently mentioned in wiki-documentation of several major GNU/Linux > distributions (e.g. Ubuntu, Arch, openSUSE). Hi, thanks for sending the patch. The one in this mail was whitespace-corrupted by your mail client, but the one you attached to the other mail was fine, so I've used that. > --- hid-apple.c.orig 2020-05-12 11:06:26.000000000 +0300 > +++ hid-apple.c 2020-05-15 20:00:00.000000000 +0300 For any next submissions, pelase send the patch in -p ab format and with full path in the kernel tree. Thanks, -- Jiri Kosina SUSE Labs